fix(detectors): Surface API error messages for cron detector creation#112630
Merged
fix(detectors): Surface API error messages for cron detector creation#112630
Conversation
saponifi3d
approved these changes
Apr 9, 2026
Contributor
saponifi3d
left a comment
There was a problem hiding this comment.
lgtm - thanks for including some todos around this too.
for the future - should we also try to standardize the API response (at least within workflow engine)? i think that might also help simplify the findFirstMessage function.
Member
Author
Yes it certainly could! Maybe we don't need to return a keyed object at all, it could just be an array of error messages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ISWF-2304
When creating a cron monitor with a slug that's already in use, the API returns a 400 with a useful error message nested inside
dataSources.slug. But the frontend was just showing a generic "Unable to create monitor" toast, which isn't helpful.This PR adds proper error surfacing in two ways:
dataSources.slugerror to thenamefieldFor both of those points, I think that there are better ways we can handle these errors by supporting them in the base form components or by adding a better abstraction to our specific form to deal with the data source mapping. But until we refactor to the use the new form components, I think this is sufficient for now.