fix(incidents): compute resolution correctly in metric issue detector#112623
Merged
fix(incidents): compute resolution correctly in metric issue detector#112623
Conversation
github-actions
bot
added
the
Scope: Backend
Contributor
Backend Test FailuresFailures on
|
kcons
changed the title
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 518a1a6. Configure here.
saponifi3d
approved these changes
Apr 10, 2026
Contributor
saponifi3d
left a comment
saponifi3d
left a comment
There was a problem hiding this comment.
lgtm!
Random thought while looking at this PR; in the future we should also revisit the resolution a little to make sure the jitter is working as expected so we can clean up some saw-toothing on evaluations.
| aggregate=validated_data["aggregate"], | ||
| time_window=timedelta(seconds=validated_data["time_window"]), | ||
| resolution=timedelta(minutes=1), | ||
| resolution=validated_data.get("resolution", timedelta(minutes=1)), |
Contributor
There was a problem hiding this comment.
👀 - should we do anything to see if the existing metric alerts have the correct resolutions?
Member
Author
There was a problem hiding this comment.
In theory, but by my count there are fewer than 87 potentially impacted cases so far in US (and probably far less than that), so I'm not entirely sure it's worth pursuing. This is more of a thing where we want to close the door before we let in the crowds.
Comment on lines
+382
to
+383
| query_type=data_source.get("query_type", SnubaQuery.Type(snuba_query.type)), | ||
| dataset=data_source.get("dataset", Dataset(snuba_query.dataset)), |
wedamija
pushed a commit
that referenced
this pull request
Apr 13, 2026
…#112623) This updates the Detector implementation of metric alerts to scale resolution based on query frequency to manage snuba capacity the same way we do for AlertRules. We had to do a few type clean-ups in the process; primarily a switch to timedelta, as we've had a few bugs related to inconsistent interpretation of int durations. Fixes ISWF-2127.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the Detector implementation of metric alerts to scale resolution based on query frequency to manage snuba capacity the same way we do for AlertRules.
We had to do a few type clean-ups in the process; primarily a switch to timedelta, as we've had a few bugs related to inconsistent interpretation of int durations.
Fixes ISWF-2127.