Skip to content

feat(slack): Pass display type from Explore URL to chartcuterie#112620

Merged
DominikB2014 merged 1 commit intomasterfrom
dominikbuszowiecki/dain-1481-pass-display-type-explore-unfurl
Apr 10, 2026
Merged

feat(slack): Pass display type from Explore URL to chartcuterie#112620
DominikB2014 merged 1 commit intomasterfrom
dominikbuszowiecki/dain-1481-pass-display-type-explore-unfurl

Conversation

@DominikB2014
Copy link
Copy Markdown
Contributor

Parses the chartType from the visualize (or aggregateField) JSON URL param in Explore Slack unfurls and passes it as the type field in the chart data sent to chartcuterie. This enables rendering bar and area charts in Slack unfurls, matching the user's selected chart type in Explore.

Also updates map_explore_query_args to prefer the visualize param (used by spans explore) over aggregateField (used by logs explore), since the traces explore page uses visualize.

The numeric chartType values from the frontend (0=bar, 1=line, 2=area) are mapped to DisplayType string values expected by chartcuterie. When no chartType is present, the type field is omitted from chart data, preserving backward compatibility (chartcuterie defaults to line).

Refs DAIN-1481

Parse the chartType from the visualize (or aggregateField) JSON URL
param in Explore Slack unfurls and pass it as the "type" field in the
chart data sent to chartcuterie. This enables rendering bar and area
charts in addition to line charts.

The numeric chartType values (0=bar, 1=line, 2=area) from the frontend
are mapped to DisplayType string values expected by chartcuterie.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 9, 2026

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 9, 2026
@DominikB2014 DominikB2014 marked this pull request as ready for review April 10, 2026 15:13
@DominikB2014 DominikB2014 requested review from a team as code owners April 10, 2026 15:13
@DominikB2014 DominikB2014 merged commit b4c5121 into master Apr 10, 2026
57 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/dain-1481-pass-display-type-explore-unfurl branch April 10, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants