Skip to content

ref(spans): remove chunk-oversized-segments option#112606

Merged
lvthanh03 merged 4 commits intomasterfrom
tony/cleanup-chunk-option
Apr 13, 2026
Merged

ref(spans): remove chunk-oversized-segments option#112606
lvthanh03 merged 4 commits intomasterfrom
tony/cleanup-chunk-option

Conversation

@lvthanh03
Copy link
Copy Markdown
Member

Removing the chunking option from being used in the business logic so that the default behaviour is chunking up a segment before flushing.

@lvthanh03 lvthanh03 requested review from a team as code owners April 9, 2026 18:47
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 9, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 77d6ad8. Configure here.

Comment thread src/sentry/spans/buffer.py
Comment thread src/sentry/spans/buffer.py
@github-actions
Copy link
Copy Markdown
Contributor

Backend Test Failures

Failures on 9a50752 in this run:

tests/sentry/spans/test_buffer.py::test_dropped_spans_emit_outcomes[cluster-nochunk]log
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/spans/test_buffer.py:1052: in test_dropped_spans_emit_outcomes
    assert mock_track_outcome.called, "track_outcome should be called when spans are dropped"
E   AssertionError: track_outcome should be called when spans are dropped
E   assert False
E    +  where False = <MagicMock name='track_outcome' id='140405987349168'>.called
tests/sentry/spans/test_buffer.py::test_dropped_spans_emit_outcomes[cluster-chunk1]log
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/spans/test_buffer.py:1052: in test_dropped_spans_emit_outcomes
    assert mock_track_outcome.called, "track_outcome should be called when spans are dropped"
E   AssertionError: track_outcome should be called when spans are dropped
E   assert False
E    +  where False = <MagicMock name='track_outcome' id='140405881445344'>.called
tests/sentry/spans/test_buffer.py::test_dropped_spans_emit_outcomes[single-nochunk]log
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/spans/test_buffer.py:1052: in test_dropped_spans_emit_outcomes
    assert mock_track_outcome.called, "track_outcome should be called when spans are dropped"
E   AssertionError: track_outcome should be called when spans are dropped
E   assert False
E    +  where False = <MagicMock name='track_outcome' id='140405858490688'>.called
tests/sentry/spans/test_buffer.py::test_dropped_spans_emit_outcomes[single-chunk1]log
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/spans/test_buffer.py:1052: in test_dropped_spans_emit_outcomes
    assert mock_track_outcome.called, "track_outcome should be called when spans are dropped"
E   AssertionError: track_outcome should be called when spans are dropped
E   assert False
E    +  where False = <MagicMock name='track_outcome' id='140405858499760'>.called

@lvthanh03 lvthanh03 merged commit 78bd357 into master Apr 13, 2026
56 checks passed
@lvthanh03 lvthanh03 deleted the tony/cleanup-chunk-option branch April 13, 2026 15:12
wedamija pushed a commit that referenced this pull request Apr 13, 2026
Removing the chunking option from being used in the business logic so
that the default behaviour is chunking up a segment before flushing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants