feat(dashboards): Track metrics for Seer dashboard create and edit flows#112595
Merged
edwardgou-sentry merged 4 commits intomasterfrom Apr 9, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 47f00f4. Configure here.
The validateDashboardAndRecordMetrics call was inside the setState updater function, which React Strict Mode can double-invoke. Move it to the setState callback to ensure it runs exactly once after state is committed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Convert seer_run_id to number in create save metric to match the edit flow. Reset seerEditApplied and seerRunId in the isEqual early return path to prevent stale state from triggering false edit metrics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
DominikB2014
approved these changes
Apr 9, 2026
edwardgou-sentry
deleted the
egou/feat/track-gen-dashboard-edit-flow-metrics
branch
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
…ows (#112595) - Adds `dashboards.seer.create.save` metric when a user saves a Seer-generated dashboard for the first time - Adds `dashboards.seer.edit.save` metric when a user saves AI-suggested changes on an existing dashboard - Adds `source` attribute (`create` | `edit`) to `dashboards.seer.validation` metric to distinguish between flows - Refactors `validateDashboardAndRecordMetrics` into shared `createFromSeerUtils` and threads `seerRunId` through the edit flow callbacks --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dashboards.seer.create.savemetric when a user saves a Seer-generated dashboard for the first timedashboards.seer.edit.savemetric when a user saves AI-suggested changes on an existing dashboardsourceattribute (create|edit) todashboards.seer.validationmetric to distinguish between flowsvalidateDashboardAndRecordMetricsinto sharedcreateFromSeerUtilsand threadsseerRunIdthrough the edit flow callbacks