feat(test): add stress-testing to known flaky tests reruns#112578
Open
JoshuaKGoldberg wants to merge 3 commits intomasterfrom
Open
feat(test): add stress-testing to known flaky tests reruns#112578JoshuaKGoldberg wants to merge 3 commits intomasterfrom
JoshuaKGoldberg wants to merge 3 commits intomasterfrom
Conversation
f4e0855 to
4b4de37
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4b4de37. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

#111860 added a way to rerun known flaky tests 50x locally or in CI. But that didn't reliably reproduce errors on all of them. I think that's because many tests only failed when the CI machine is separately slow, so if the machine is running fine, running 1x vs 50x doesn't make a difference.
This changes flaky tests to run under each of 5 different simulated slowdowns, 10x each (so still 50x each total):
withDelayedFetch: Simulates a slow network by adding delays to global fetch calls.withMainThreadCpuLoad: Simulates an overloaded main thread by doing busy-work on a fixed interval.withMemoryPressure: Simulates low available memory by retaining a large buffer of bytes data.withMicrotaskChurn: Simulates a busy machine by continuously queueing microtasks.withRealWallClockDelay: Simulates a slow machine with many timers by continuously running no-op async delays.We can see in this PR's CI that although the flaky tests still don't always fail, failures do happen a lot more now. 🥳
Any CI failures (e.g. Jest (1), Jest (2)) are IMO expected and shouldn't block review. The tests themselves aren't changed, and
masterdoesn't run with the flake label.