Skip to content

ref(charts): Remove browserHistory usage from BarChartZoom component #112546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shashjar merged 1 commit into from
Apr 8, 2026
+4 −2
Merged

ref(charts): Remove browserHistory usage from BarChartZoom component #112546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions static/app/components/charts/barChartZoom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import type {
EChartFinishedHandler,
ECharts,
} from 'sentry/types/echarts';
import {browserHistory} from 'sentry/utils/browserHistory';
import {useNavigate} from 'sentry/utils/useNavigate';

type RenderProps = {
dataZoom: ReturnType<typeof DataZoomInside>;
Expand Down Expand Up @@ -81,6 +81,8 @@ export function BarChartZoom({
paramStart,
xAxisIndex,
}: Props) {
const navigate = useNavigate();

/**
* Enable zoom immediately instead of having to toggle to zoom
*/
Expand Down Expand Up @@ -127,7 +129,7 @@ export function BarChartZoom({
if (onHistoryPush) {
onHistoryPush(start, end);
} else {
browserHistory.push(target);
navigate(target);
}
} else {
// Dispatch the restore action here to stop ECharts from zooming
Expand Down
Loading