Skip to content

ref(preprod): post task deployment, remove no longer needed fallback#112528

Merged
NicoHinderling merged 1 commit intomasterfrom
04-08-ref_preprod_post_task_deployment_remove_no_longer_needed_fallback
Apr 8, 2026
Merged

ref(preprod): post task deployment, remove no longer needed fallback#112528
NicoHinderling merged 1 commit intomasterfrom
04-08-ref_preprod_post_task_deployment_remove_no_longer_needed_fallback

Conversation

@NicoHinderling
Copy link
Copy Markdown
Contributor

@NicoHinderling NicoHinderling commented Apr 8, 2026 •
edited
Loading

Follow-up to #112527. Removes the artifact.date_added fallback and makes triggered_at a required parameter now that all producers pass it.

@NicoHinderling Graphite App
Copy link
Copy Markdown
Contributor Author

NicoHinderling commented Apr 8, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NicoHinderling NicoHinderling mentioned this pull request Apr 8, 2026
Merged
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 8, 2026
@NicoHinderling NicoHinderling marked this pull request as ready for review April 8, 2026 20:53
@NicoHinderling NicoHinderling requested a review from a team as a code owner April 8, 2026 20:53
Base automatically changed from 04-08-ref_preprod_fix_build_e2e_time_for_reruns to master April 8, 2026 21:09
@NicoHinderling
Copy link
Copy Markdown
Contributor Author

NicoHinderling commented Apr 8, 2026

cant merge until #112527 is deployed

@NicoHinderling NicoHinderling force-pushed the 04-08-ref_preprod_post_task_deployment_remove_no_longer_needed_fallback branch from 37c9746 to 0c74a43 Compare April 8, 2026 21:12
@NicoHinderling NicoHinderling merged commit 94511a0 into master Apr 8, 2026
57 checks passed
@NicoHinderling NicoHinderling deleted the 04-08-ref_preprod_post_task_deployment_remove_no_longer_needed_fallback branch April 8, 2026 22:33
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
@NicoHinderling @george-sentry
ref(preprod): post task deployment, remove no longer needed fallback (#…
45b6a47 
…112528)

Follow-up to #112527. Removes the `artifact.date_added` fallback and
makes `triggered_at` a required parameter now that all producers pass
it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtopo27 mtopo27 mtopo27 approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NicoHinderling @mtopo27