Skip to content

feat(preprod): Check for actual build data when showing mobile builds tab#112525

Merged
NicoHinderling merged 2 commits intomasterfrom
feat/mobile-builds-tab-data-check
Apr 8, 2026
Merged

feat(preprod): Check for actual build data when showing mobile builds tab#112525
NicoHinderling merged 2 commits intomasterfrom
feat/mobile-builds-tab-data-check

Conversation

@NicoHinderling
Copy link
Copy Markdown
Contributor

Adjust the Mobile Builds tab visibility on the Releases page to also check
for actual build data, not just whether the project has a mobile platform.

Previously, the tab showed purely based on isMobileRelease() — a client-side
platform check. Now we also probe the existing /builds/ endpoint with
per_page=1 to see if any preprod builds exist for the selected projects
and time range. The tab shows if either condition is true:

  1. The builds endpoint returns at least one result
  2. At least one selected project has a mobile platform (existing fallback)

The probe query is gated behind the preprod-frontend-routes feature flag
and uses a 60s stale time. Only date-related params are passed to avoid
spurious refetches from unrelated URL query changes.

Refs EME-706

… tab

Query the builds endpoint with per_page=1 to check if preprod builds
exist for the selected projects and time range. Show the Mobile Builds
tab if either actual builds data exists or the project has a mobile
platform (existing fallback).

The probe query is gated behind the preprod-frontend-routes feature
flag and uses a 60s stale time to avoid unnecessary refetches.

Refs EME-706
Co-Authored-By: Claude <noreply@anthropic.com>
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 8, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 8, 2026
@NicoHinderling NicoHinderling marked this pull request as ready for review April 8, 2026 20:45
@NicoHinderling NicoHinderling requested a review from a team as a code owner April 8, 2026 20:45
Comment thread static/app/views/releases/list/index.tsx
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 851925b. Configure here.

Comment thread static/app/views/releases/list/index.tsx
…etch

Add MockApiClient response for /builds/ endpoint in release list tests.
Use keepPreviousData to prevent the mobile builds tab from flickering
when query keys change during filter updates.
@NicoHinderling NicoHinderling merged commit 6f98d27 into master Apr 8, 2026
64 of 65 checks passed
@NicoHinderling NicoHinderling deleted the feat/mobile-builds-tab-data-check branch April 8, 2026 21:19
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
… tab (#112525)

Adjust the Mobile Builds tab visibility on the Releases page to also
check
for actual build data, not just whether the project has a mobile
platform.

Previously, the tab showed purely based on `isMobileRelease()` — a
client-side
platform check. Now we also probe the existing `/builds/` endpoint with
`per_page=1` to see if any preprod builds exist for the selected
projects
and time range. The tab shows if either condition is true:

1. The builds endpoint returns at least one result
2. At least one selected project has a mobile platform (existing
fallback)

The probe query is gated behind the `preprod-frontend-routes` feature
flag
and uses a 60s stale time. Only date-related params are passed to avoid
spurious refetches from unrelated URL query changes.

Refs EME-706

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants