feat(integrations): Genericise repository syncing task#112519
Merged
feat(integrations): Genericise repository syncing task#112519
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
wedamija
force-pushed
the
danf/move-sync-repos-task
branch
from
987d043 to
c11d6af
Compare
wedamija
force-pushed
the
danf/sync-repos-task-generalize
branch
from
4fd70b5 to
95097c5
Compare
wedamija
changed the title
shashjar
approved these changes
Apr 8, 2026
wedamija
added a commit
that referenced
this pull request
Apr 8, 2026
Required to get #112519 working for all scms. integration_id and installation are the same, but different scms use them. I don't want to refactor how the scms work, so just providing both.
This switches over the repository syncing task to be able to run for most SCM providers.
wedamija
force-pushed
the
danf/sync-repos-task-generalize
branch
from
95097c5 to
6749a24
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6749a24. Configure here.
| restored_ids = sentry_disabled_ids & provider_external_ids | ||
|
|
||
| metric_tags = { | ||
| "provider": integration.provider, |
Contributor
There was a problem hiding this comment.
GHE sync crashes on ApiError due to missing method
High Severity
GitHubEnterpriseIntegration does not override is_rate_limited_error; it inherits the base IntegrationInstallation implementation which raises NotImplementedError. Before this PR, GHE integrations always exited early because the feature flag was GitHub-specific. Now that dedicated github_enterprise-repo-auto-sync flags are registered and checked, GHE can reach the except ApiError handler. When any ApiError occurs, installation.is_rate_limited_error(e) raises NotImplementedError, masking the original error and preventing the raise from re-raising the ApiError for proper task retry.
Reviewed by Cursor Bugbot for commit 6749a24. Configure here.
wedamija
added a commit
that referenced
this pull request
Apr 9, 2026
Required to get #112519 working for all scms. integration_id and installation are the same, but different scms use them. I don't want to refactor how the scms work, so just providing both.
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
This uses more generic functions in the syncing task. It turns out there's more work to do for each provider to make them generic, so not enabling everything yet.
wedamija
added a commit
that referenced
this pull request
Apr 10, 2026
Required to get #112519 working for all scms. integration_id and installation are the same, but different scms use them. I don't want to refactor how the scms work, so just providing both.
wedamija
added a commit
that referenced
this pull request
Apr 10, 2026
…12545) Required to get #112519 working for all scms. Expand the periodic repo sync from GitHub-only to provider-agnostic. The task now uses each provider's get_repositories() and external_id instead of GitHub-specific API calls, with per-provider feature flags to control rollout. Currently enabled for GitHub, GitHub Enterprise, and VSTS. GitLab and Bitbucket are blocked on a pre-existing issue where create_repositories eagerly creates webhooks for all repos before checking if they already exist. Perforce lacks external_id support. <!-- Describe your PR here. -->
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses more generic functions in the syncing task. It turns out there's more work to do for each provider to make them generic, so not enabling everything yet.