Skip to content

ref(cells): Implement org member invite redirect from old path to new#112513

Merged
lynnagara merged 6 commits intomasterfrom
add-org-invite-redirect
Apr 9, 2026
Merged

ref(cells): Implement org member invite redirect from old path to new#112513
lynnagara merged 6 commits intomasterfrom
add-org-invite-redirect

Conversation

@lynnagara
Copy link
Copy Markdown
Member

We have to support the old invite urls for up to INVITE_DAYS_VALID (30 days) however putting this web redirect in place now allows us to clean up the rest of the frontend and api logic and other settings (such as is_historical_monolith_region handling) that was all connected to the legacy route.

We have to support the old invite urls for up to INVITE_DAYS_VALID (30 days)
however putting this web redirect in place now allows us to clean up the rest
of the frontend and api logic and other settings (such as `is_historical_monolith_region`
handling) that was all connected to the legacy route.
@lynnagara lynnagara requested a review from a team as a code owner April 8, 2026 19:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 8, 2026
@lynnagara lynnagara requested a review from a team April 8, 2026 19:57
Comment thread src/sentry/web/frontend/accept_organization_invite_redirect.py
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f77e5e9. Configure here.

Comment thread src/sentry/web/frontend/accept_organization_invite_redirect.py
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Backend Test Failures

Failures on e244009 in this run:

tests/sentry/web/frontend/test_accept_organization_invite_redirect.py::AcceptOrganizationInviteRedirectViewTest::test_redirects_legacy_invite_to_org_scoped_routelog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/web/frontend/test_accept_organization_invite_redirect.py:17: in test_redirects_legacy_invite_to_org_scoped_route
    assert response.status_code == 302
E   assert 200 == 302
E    +  where 200 = <HttpResponse status_code=200, "text/html">.status_code

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Backend Test Failures

Failures on c5a9bc8 in this run:

tests/sentry/web/frontend/test_accept_organization_invite_redirect.py::AcceptOrganizationInviteRedirectViewTest::test_redirects_legacy_invite_to_org_scoped_routelog
[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/web/frontend/test_accept_organization_invite_redirect.py:17: in test_redirects_legacy_invite_to_org_scoped_route
    assert response.status_code == 302
E   assert 200 == 302
E    +  where 200 = <HttpResponse status_code=200, "text/html">.status_code

@lynnagara lynnagara merged commit 754785e into master Apr 9, 2026
77 checks passed
@lynnagara lynnagara deleted the add-org-invite-redirect branch April 9, 2026 18:17
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
…#112513)

We have to support the old invite urls for up to INVITE_DAYS_VALID (30
days) however putting this web redirect in place now allows us to clean
up the rest of the frontend and api logic and other settings (such as
`is_historical_monolith_region` handling) that was all connected to the
legacy route.
lynnagara added a commit that referenced this pull request Apr 9, 2026
- removes the old /accept/:memberId/:token/ route. The component now only mounts via the org-scoped
  /accept/:orgId/:memberId/:token/ route
- this is safe now because #112513 added a redirect that
ensures the old route is never hit anymore
- the react component is also simplified as it no longer has to handle the case where an org
is not present
lynnagara added a commit that referenced this pull request Apr 10, 2026
- removes the old /accept/:memberId/:token/ route. The component now
only mounts via the org-scoped /accept/:orgId/:memberId/:token/ route
- this is safe now because
#112513 added a redirect that
ensures the old route is never hit anymore
- the react component is also simplified as it no longer has to handle
the case where an org is not present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants