Skip to content

feat(project): increase securityTokenHeader max_length from 20 to 64 #112483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcramer merged 1 commit into from
Apr 10, 2026
+15 −1
Merged

feat(project): increase securityTokenHeader max_length from 20 to 64 #112483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/core/endpoints/project_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ class ProjectAdminSerializer(ProjectMemberSerializer):
r"^[-a-zA-Z0-9+/=\s]+$", max_length=255, allow_blank=True
)
securityTokenHeader = serializers.RegexField(
r"^[a-zA-Z0-9_\-]+$", max_length=20, allow_blank=True
r"^[a-zA-Z0-9_\-]+$", max_length=64, allow_blank=True
)
verifySSL = serializers.BooleanField(required=False)

Expand Down
14 changes: 14 additions & 0 deletions tests/sentry/core/endpoints/test_project_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,6 +844,20 @@ def test_security_token_header(self) -> None:
assert self.project.get_option("sentry:token_header") == ""
assert resp.data["securityTokenHeader"] == ""

def test_security_token_header_max_length(self) -> None:
# exactly 64 characters should succeed
value = "X-" + "A" * 62
assert len(value) == 64
resp = self.get_success_response(self.org_slug, self.proj_slug, securityTokenHeader=value)
assert self.project.get_option("sentry:token_header") == value
assert resp.data["securityTokenHeader"] == value

# 65 characters should fail
resp = self.get_error_response(
self.org_slug, self.proj_slug, securityTokenHeader="X-" + "A" * 63, status_code=400
)
assert b"securityTokenHeader" in resp.content

def test_verify_ssl(self) -> None:
resp = self.get_success_response(self.org_slug, self.proj_slug, verifySSL=False)
assert self.project.get_option("sentry:verify_ssl") is False
Expand Down
Loading