feat(issue-details): Add android native tombstones onboarding banner#112478
feat(issue-details): Add android native tombstones onboarding banner#112478
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 900c188. Configure here.
malwilley
left a comment
malwilley
left a comment
There was a problem hiding this comment.
Code looks good, but product-wise:
Is there any way to make this banner have a smaller footprint? For some history, during the issue details redesign there were many of such banners which made the page look very intimidating for new users. So they were all removed. We really want to avoid adding content like this (especially above the stack trace) if possible. So if there is any way to notify users about this without such a large banner that would be preferable!
|
@malwilley do you have any suggestions? I think for new users it's not a concern, since we include this flag into the default config anyway. Also, this banner would be there for a few months until we flip this flag to |
Show an onboarding banner on the issue details page when a native crash was captured via the Android NDK integration with only a signalhandler mechanism. The banner includes tabbed code snippets (AndroidManifest.xml, Kotlin, Java) showing how to enable tombstone collection, with dismiss and snooze support via the prompts-activity API. Depends on #112477 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Render the banner card directly without a collapsible section wrapper, matching the desired UI. Also restores the isError bail-out that was temporarily removed for local testing with dev-ui. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add explicit ExceptionValue type annotation for the mechanism check callback parameter, and add fallback for CodeBlock children to satisfy the string type constraint. Restore isError bail-out. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use exact SDK name match instead of startsWith to exclude React Native and Flutter SDKs which share the prefix - Replace styled BannerTitle/BannerDescription with Heading and Text core components per frontend guidelines Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…anner Show SDK-specific code snippets based on the event's sdk.name: - sentry.native.android → AndroidManifest.xml, Kotlin, Java - sentry.native.android.react-native → JavaScript - sentry.native.android.flutter → Dart Each snippet includes the minimum SDK version required as a comment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The color was copied from replay panel which has a dark background. This banner uses a light background and the icon already uses variant="muted", so the white color rule was unused. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
romtsn
force-pushed
the
romtsn/feat/android-tombstones-onboarding-banner
branch
from
cea662b to
1b577c1
Compare
|
as discussed with @malwilley internally, we're gonna ship this and drop the banner after a new SDK major or after a while when we see enough adoption of the feature. |
2 participants
Show an onboarding banner on the issue details page when a native crash was
captured via the Android NDK integration with only a signalhandler mechanism.
The banner encourages users to enable tombstone collection for richer crash
reports.
Includes:
Depends on #112477 (backend prompt registration) — land that first.