ref(preprod): Remove image proxy endpoint in favor of objectstore proxy#112469
Draft
ref(preprod): Remove image proxy endpoint in favor of objectstore proxy#112469
Conversation
github-actions
bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
lcian
changed the title
…tore proxy directly The objectstore proxy endpoint already sets the content type, so the dedicated image proxy endpoint is redundant. Frontend now constructs objectstore proxy URLs directly for all image fetches.
lcian
force-pushed
the
lcian/preprod-remove-image-proxy-endpoint
branch
2 times, most recently
from
573c15f to
1f563f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProjectPreprodArtifactImageEndpointis redundant, asobjectstorealready returns aContent-Typeheader with responses.This removes that endpoint, and makes frontend requests for snapshot images and app icons hit the Objectstore proxy endpoint directly instead, as the diff images code path already does (see
diffImageBaseUrlinstatic/app/views/preprod/snapshots/snapshots.tsx).Some components were using
projectId: string | nullbefore which contained the slug, so I renamed it toprojectSlugand addedprojectId: number | nullto hold the numeric project ID which we need to form the correct Objectstore key.