Skip to content

ref(utils): simplify useDimensions types by removing type parameter #112460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaKGoldberg merged 2 commits into from
Apr 9, 2026
Merged

ref(utils): simplify useDimensions types by removing type parameter #112460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24b0924
ref(utils): simplify useDimensions runtime and types
JoshuaKGoldberg Apr 8, 2026
b34d1b0
ref: put back the options object
JoshuaKGoldberg Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/app/components/checkInTimeline/checkInTimeline.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function generateMockTickData(
export default Storybook.story('CheckInTimeline', story => {
story('Simple', () => {
const elementRef = useRef<HTMLDivElement>(null);
const {width: timelineWidth} = useDimensions<HTMLDivElement>({elementRef});
const {width: timelineWidth} = useDimensions({elementRef});
const timeWindowConfig = useTimeWindowConfig({timelineWidth});

const [secondsGap, setSecondsGap] = useState(60);
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/replays/breadcrumbs/replayTimeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export function ReplayTimeline() {
const [timelineScale] = useTimelineScale();

const stackedRef = useRef<HTMLDivElement>(null);
const {width} = useDimensions<HTMLDivElement>({elementRef: stackedRef});
const {width} = useDimensions({elementRef: stackedRef});

if (!replay) {
return <Placeholder height="20px" />;
Expand Down
4 changes: 2 additions & 2 deletions static/app/utils/useDimensions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ import type {RefObject} from 'react';
import {useCallback, useLayoutEffect, useState} from 'react';
import {useResizeObserver} from '@react-aria/utils';

interface Props<Element extends HTMLElement> {
interface Props {
Comment thread
JoshuaKGoldberg marked this conversation as resolved.
elementRef: RefObject<Element | null>;
}

/**
* Returns a ref to be added to an element and returns the dimensions of that element
*/
export function useDimensions<Element extends HTMLElement>({elementRef}: Props<Element>) {
export function useDimensions({elementRef}: Props) {
const [dimensions, setDimensions] = useState({height: 0, width: 0});

const element = elementRef.current;
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/alerts/rules/uptime/detailsTimeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ interface Props {
export function DetailsTimeline({uptimeDetector, onStatsLoaded}: Props) {
const {id} = uptimeDetector;
const elementRef = useRef<HTMLDivElement>(null);
const {width: containerWidth} = useDimensions<HTMLDivElement>({elementRef});
const {width: containerWidth} = useDimensions({elementRef});
const timelineWidth = useDebouncedValue(containerWidth, 500);

const timeWindowConfig = useTimeWindowConfig({
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/detectors/components/detectorListTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export function DetectorListTable({
);

const elementRef = useRef<HTMLDivElement>(null);
const {width: containerWidth} = useDimensions<HTMLDivElement>({elementRef});
const {width: containerWidth} = useDimensions({elementRef});
const timelineWidth = useDebouncedValue(containerWidth, 1000);
const timeWindowConfig = useTimeWindowConfig({timelineWidth});

Expand Down
2 changes: 1 addition & 1 deletion static/app/views/detectors/hooks/useMonitorsScheduleSamples.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export function useMonitorsScheduleSamples({
...detectorFields
}: UseMonitorsScheduleSamplesOptions) {
const timeLineWidthTrackerRef = useRef<HTMLDivElement>(null);
const {width: timelineWidth} = useDimensions<HTMLDivElement>({
const {width: timelineWidth} = useDimensions({
elementRef: timeLineWidthTrackerRef,
});

Expand Down
2 changes: 1 addition & 1 deletion static/app/views/detectors/list/cron.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function VisualizationCell({detector}: {detector: CronDetector}) {
const cronEnvironments = detector.dataSources[0].queryObj.environments;

const elementRef = useRef<HTMLDivElement>(null);
const {width: containerWidth} = useDimensions<HTMLDivElement>({elementRef});
const {width: containerWidth} = useDimensions({elementRef});
const timelineWidth = useDebouncedValue(containerWidth, 1000);
const timeWindowConfig = useTimeWindowConfig({timelineWidth});
const {data: monitorStats, isPending} = useMonitorStats({
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/detectors/list/uptime.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function VisualizationCell({detector}: {detector: UptimeDetector}) {
const uptimeDetectorId = detector.id;

const elementRef = useRef<HTMLDivElement>(null);
const {width: containerWidth} = useDimensions<HTMLDivElement>({elementRef});
const {width: containerWidth} = useDimensions({elementRef});
const timelineWidth = useDebouncedValue(containerWidth, 1000);
const timeWindowConfig = useTimeWindowConfig({timelineWidth});

Expand Down
2 changes: 1 addition & 1 deletion static/app/views/insights/crons/components/detailsTimeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function DetailsTimeline({monitor, onStatsLoaded, onEnvironmentUpdated}:
const queryClient = useQueryClient();

const elementRef = useRef<HTMLDivElement>(null);
const {width: containerWidth} = useDimensions<HTMLDivElement>({elementRef});
const {width: containerWidth} = useDimensions({elementRef});
const timelineWidth = useDebouncedValue(containerWidth, 500);

// Use the nextCheckIn timestamp from the earliest scheduled environment as a
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/insights/crons/components/mockTimelineVisualization.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export function MockTimelineVisualization({schedule}: Props) {
};

const elementRef = useRef<HTMLDivElement>(null);
const {width: timelineWidth} = useDimensions<HTMLDivElement>({elementRef});
const {width: timelineWidth} = useDimensions({elementRef});

const sampleDataQueryKey = [
getApiUrl('/organizations/$organizationIdOrSlug/monitors-schedule-data/', {
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/insights/crons/components/overviewTimeline/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export function OverviewTimeline({monitorList}: Props) {
const location = useLocation();

const elementRef = useRef<HTMLDivElement>(null);
const {width: containerWidth} = useDimensions<HTMLDivElement>({elementRef});
const {width: containerWidth} = useDimensions({elementRef});
const timelineWidth = useDebouncedValue(containerWidth, 1000);

const timeWindowConfig = useTimeWindowConfig({timelineWidth});
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/insights/uptime/components/overviewTimeline/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ interface Props {

export function OverviewTimeline({uptimeDetectors}: Props) {
const elementRef = useRef<HTMLDivElement>(null);
const {width: containerWidth} = useDimensions<HTMLDivElement>({elementRef});
const {width: containerWidth} = useDimensions({elementRef});
const timelineWidth = useDebouncedValue(containerWidth, 500);

const timeWindowConfig = useTimeWindowConfig({timelineWidth});
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/issueDetails/streamline/issueCronCheckTimeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ function useCronLegendStatuses({

export function IssueCronCheckTimeline({group}: {group: Group}) {
const elementRef = useRef<HTMLDivElement>(null);
const {width: containerWidth} = useDimensions<HTMLDivElement>({elementRef});
const {width: containerWidth} = useDimensions({elementRef});
const timelineWidth = useDebouncedValue(containerWidth, 500);
const timeWindowConfig = useIssueTimeWindowConfig({timelineWidth, group});

Expand Down
2 changes: 1 addition & 1 deletion static/app/views/issueDetails/streamline/issueUptimeCheckTimeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export function useUptimeIssueDetectorId({
export function IssueUptimeCheckTimeline({group}: {group: Group}) {
const detectorId = useUptimeIssueDetectorId({groupId: group.id});
const elementRef = useRef<HTMLDivElement>(null);
const {width: containerWidth} = useDimensions<HTMLDivElement>({elementRef});
const {width: containerWidth} = useDimensions({elementRef});
const timelineWidth = useDebouncedValue(containerWidth, 500);
const timeWindowConfig = useIssueTimeWindowConfig({timelineWidth, group});

Expand Down
Loading