feat(np): Adds Discord metric alert renderer #112420
Merged
GabeVillalobos merged 2 commits intomasterfrom Apr 8, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
saponifi3d
approved these changes
Apr 8, 2026
| assert renderer is DiscordNotificationProvider.default_renderer | ||
|
|
||
|
|
||
| class DiscordMetricAlertRendererTest(MetricAlertHandlerBase): |
Contributor
There was a problem hiding this comment.
i really like how you broke down these tests and organized everything 🙏
Co-authored-by: Josh Callender <1569818+saponifi3d@users.noreply.github.com>
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves ISWF-2313
Implements Discord's Metric Alert renderer. Testing to be done in prod against our test organization.