Skip to content

feat(slack): Add frontend pipeline step for Slack integration setup#112417

Merged
evanpurkhiser merged 1 commit intomasterfrom
evanpurkhiser/feat-slack-add-frontend-pipeline-step-for-slack-integration-setup
Apr 8, 2026
Merged

feat(slack): Add frontend pipeline step for Slack integration setup#112417
evanpurkhiser merged 1 commit intomasterfrom
evanpurkhiser/feat-slack-add-frontend-pipeline-step-for-slack-integration-setup

Conversation

@evanpurkhiser
Copy link
Copy Markdown
Member

Register the Slack integration in the pipeline registry with a single
OAuthLoginStep component. This is the simplest integration frontend since
Slack only requires an OAuth authorization flow with no additional
configuration steps.

Ref VDY-42

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner April 7, 2026 21:34
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 7, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 7, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 65b70bf. Configure here.

popup={{height: 900}}
/>
);
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New OAuth step duplicates existing GitLab implementation

Low Severity

SlackOAuthLoginStep is nearly identical to GitLabOAuthLoginStep in pipelineIntegrationGitLab.tsx — same type signature, same handleOAuthCallback body, same OAuthLoginStep rendering — differing only in serviceName and the popup option. As more OAuth-only integrations are added, this boilerplate will keep getting copied. A small shared factory (parameterized by serviceName and optional PopupOptions) would eliminate the duplication.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 65b70bf. Configure here.

Register the Slack integration in the pipeline registry with a single
OAuthLoginStep component. This is the simplest integration frontend since
Slack only requires an OAuth authorization flow with no additional
configuration steps.

Ref [VDY-42](https://linear.app/getsentry/issue/VDY-42/slack-api-driven-integration-setup)
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-slack-add-frontend-pipeline-step-for-slack-integration-setup branch from 65b70bf to aaa5747 Compare April 8, 2026 14:30
@evanpurkhiser evanpurkhiser merged commit 0838315 into master Apr 8, 2026
65 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/feat-slack-add-frontend-pipeline-step-for-slack-integration-setup branch April 8, 2026 15:53
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
…112417)

Register the Slack integration in the pipeline registry with a single
OAuthLoginStep component. This is the simplest integration frontend
since
Slack only requires an OAuth authorization flow with no additional
configuration steps.

Ref
[VDY-42](https://linear.app/getsentry/issue/VDY-42/slack-api-driven-integration-setup)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants