fix(billing): Skip missing plan buckets#112416
Closed
brendanhsentry wants to merge 2 commits intomasterfrom
Closed
fix(billing): Skip missing plan buckets#112416brendanhsentry wants to merge 2 commits intomasterfrom
brendanhsentry wants to merge 2 commits intomasterfrom
Conversation
Return null from getBucket when plan data is missing so billing views and checkout flows can keep rendering. Fall back to zero-priced bucket values for unsupported categories and cover the regression with focused tests. Co-Authored-By: GPT-5.4 <noreply@example.com> Made-with: Cursor
github-actions
bot
added
the
Scope: Frontend
Keep the billing null-bucket fallback type-safe so frontend type checks pass when unsupported plan categories are skipped. Co-Authored-By: GPT-5.4 <noreply@example.com> Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of raising an error in
getBucketwe should just skip categories if it's not part of the plan's categories.FIXES JAVASCRIPT-38NB