Skip to content

chore(aci): add flag to GET OrganizationAlertRuleIndexEndpoint#112401

Merged
klochek merged 1 commit intomasterfrom
christopherklochek/iswf-2382-roll-out-organizationalertruleindexendpoint-get
Apr 8, 2026
Merged

chore(aci): add flag to GET OrganizationAlertRuleIndexEndpoint#112401
klochek merged 1 commit intomasterfrom
christopherklochek/iswf-2382-roll-out-organizationalertruleindexendpoint-get

Conversation

@klochek
Copy link
Copy Markdown
Contributor

@klochek klochek commented Apr 7, 2026

No description provided.

@klochek klochek requested a review from a team as a code owner April 7, 2026 20:08
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 7, 2026

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 7, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d865ebb. Configure here.

use_workflow_engine = (
features.has("organizations:workflow-engine-rule-serializers", organization)
or method_flag is not None
and features.has(method_flag, organization)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing parentheses in boolean expression risks misinterpretation

Medium Severity

The or/and expression in use_workflow_engine omits the explicit parentheses around method_flag is not None and features.has(method_flag, organization) that both other identical implementations of this pattern (in rule.py and bases.py) include. While Python's operator precedence makes and bind tighter than or so the result happens to be correct, the outer parentheses (used for line continuation) visually suggest a different grouping and make the expression easy to misread as (... or method_flag is not None) and features.has(...).

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d865ebb. Configure here.

@klochek klochek merged commit 2a7ebf3 into master Apr 8, 2026
80 checks passed
@klochek klochek deleted the christopherklochek/iswf-2382-roll-out-organizationalertruleindexendpoint-get branch April 8, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants