-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(traces): Disable links to traces older than 30 days #112377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nsdeschenes
wants to merge
39
commits into
master
Choose a base branch
from
nd/EXP-647/chore-traces-disable-links-to-old-traces-app-wide
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
9ad4723
ref(traces): Extract isPartialSpanOrTraceData to shared utility
nsdeschenes 4409cec
feat(traces): Disable trace links older than 30 days on high-traffic …
nsdeschenes 7a47352
feat(traces): Disable trace links older than 30 days on insights and …
nsdeschenes 06a3ac6
feat(traces): Disable trace links older than 30 days on profiling and…
nsdeschenes 67b2e74
ref(traces): Remove unused export from TRACE_DATA_RETENTION_DAYS
nsdeschenes 36d92f8
fix(traces): Resolve tsgo type errors in trace utilities
nsdeschenes 50bface
fix(traces): Remove incorrect retention check from span links
nsdeschenes 6b54030
fix(traces): Remove retention check from trace attribute link in trac…
nsdeschenes 047dda4
ref(traces): Deduplicate minimap JSX in event comparison display
nsdeschenes f135725
ref(traces): Move DisabledTraceLink to components/explore
nsdeschenes f28fcb4
chore(explore): Add CODEOWNERS entry for components/explore
nsdeschenes e29aa02
fix(traces): Preserve issue event links for old trace data
nsdeschenes 1c0e26c
fix(traces): Add tooltip to disabled trace link in agents drawer
nsdeschenes 1814fe4
ref(traces): Remove dead re-export and fix import paths
nsdeschenes 16cd1bf
fix(traces): Add tooltips to disabled trace links missing explanations
nsdeschenes 842ae0e
ref(traces): Migrate simple disabled trace links to DisabledTraceLink
nsdeschenes ef0d6e0
ref(traces): Migrate complex disabled trace links to DisabledTraceLink
nsdeschenes 60ec9a6
test(traces): Update fieldRenderer tests for DisabledTraceLink
nsdeschenes bf19f91
fix(traces): Only disable old trace links for event ID column
nsdeschenes a1c9caa
fix(traces): Fix minor bugs in disabled trace link rollout
nsdeschenes 9c8af0a
fix(traces): Disable trace column links for data older than 30 days
nsdeschenes 91414ce
ref(traces): Scope traceViewLink to the id branch in web vitals table
nsdeschenes 3354073
fix(traces): Close old trace link regressions
nsdeschenes cb188ef
fix(traces): Preserve truncation for disabled web vitals links
nsdeschenes e908096
ref(traces): Block old trace redirects in event detail pages
nsdeschenes 6241dde
ref(traces): Disable trace preview and waterfall overlay for old events
nsdeschenes 4633ead
ref(traces): Disable links in trace drawer for old trace data
nsdeschenes 266e515
ref(traces): Disable trace links in transaction tables for old data
nsdeschenes 168f928
fix(traces): Use >= for 30-day boundary and improve test coverage
nsdeschenes 820202f
fix(traces): Normalize query timestamp to string for type safety
nsdeschenes 21be9ca
fix(traces): Hoist isOld check out of flatMap and document normalizeT…
nsdeschenes 2bdabe5
fix(traces): Add missing disabled tooltips and simplify old-data checks
nsdeschenes 4390ae4
fix(traces): Skip old-trace error when redirecting to issue events
nsdeschenes a236ec1
fix(profiling): Disable trace link for old data in profile events table
nsdeschenes d167f9e
fix(web-vitals): Show trace ID consistently in disabled and linked st…
nsdeschenes 2b65aac
Tidy up things
nsdeschenes fe77b0a
Create tooltip wrapper component
nsdeschenes 354cc68
Use new tooltip helper component
nsdeschenes fc10990
test(performance): Fix spanEvidenceKeyValueList tests after trace lin…
nsdeschenes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test expects wrong tooltip text from DisabledTraceLinkTooltip
Medium Severity
The tests assert the tooltip text is
"Trace data is only available for the last 30 days", but theDisabledTraceLinkTooltipcomponent actually renders"Trace is older than 30 days"(fromdisabledTraceLink.tsxline 35). The component wrapping theLinkButtonineventTraceView.tsxandprofileEventEvidence.tsxusesDisabledTraceLinkTooltip, so these tests will fail due to the string mismatch.Additional Locations (1)
static/app/components/events/profileEventEvidence.spec.tsx#L100-L104Reviewed by Cursor Bugbot for commit fc10990. Configure here.