feat(preprod): Add installable attribute to EAP alias mappings#112363
Merged
feat(preprod): Add installable attribute to EAP alias mappings#112363
Conversation
Register PREPROD in INTERNAL_TO_PUBLIC_ALIAS_MAPPINGS so the EAP attributes endpoint translates has_installable_file to installable. This makes the installable filter appear in the mobile builds search bar dropdown. Refs EME-868 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
trevor-e
approved these changes
Apr 7, 2026
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
Register PREPROD in the shared `INTERNAL_TO_PUBLIC_ALIAS_MAPPINGS` infrastructure so the EAP attributes endpoint translates `has_installable_file` → `installable`. This makes the `installable` boolean filter appear in the mobile builds search bar dropdown on the Distribution view. Previously, the PREPROD trace item type had no entry in the alias mapping dicts in `search/eap/utils.py`, so `translate_internal_to_public_alias()` returned the raw internal name `has_installable_file`. The frontend `filterToAllowedKeys()` then couldn't match it against the allowlist (which expects `installable`), so the attribute was silently filtered out. The mapping dict is built dynamically from `PREPROD_SIZE_ATTRIBUTE_DEFINITIONS`, so any future aliased PREPROD attributes will automatically be included. Refs EME-868 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register PREPROD in the shared
INTERNAL_TO_PUBLIC_ALIAS_MAPPINGSinfrastructure so the EAP attributes endpoint translateshas_installable_file→installable. This makes theinstallableboolean filter appear in the mobile builds search bar dropdown on the Distribution view.Previously, the PREPROD trace item type had no entry in the alias mapping dicts in
search/eap/utils.py, sotranslate_internal_to_public_alias()returned the raw internal namehas_installable_file. The frontendfilterToAllowedKeys()then couldn't match it against the allowlist (which expectsinstallable), so the attribute was silently filtered out.The mapping dict is built dynamically from
PREPROD_SIZE_ATTRIBUTE_DEFINITIONS, so any future aliased PREPROD attributes will automatically be included.Refs EME-868