-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(preprod): Add snapshot PR comments toggle to project settings #112362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+74
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
static/app/views/settings/project/preprod/snapshotPrCommentsToggle.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| import {Flex, Stack} from '@sentry/scraps/layout'; | ||
| import {Switch} from '@sentry/scraps/switch'; | ||
| import {Text} from '@sentry/scraps/text'; | ||
|
|
||
| import { | ||
| addErrorMessage, | ||
| addLoadingMessage, | ||
| addSuccessMessage, | ||
| } from 'sentry/actionCreators/indicator'; | ||
| import {Panel} from 'sentry/components/panels/panel'; | ||
| import {PanelBody} from 'sentry/components/panels/panelBody'; | ||
| import {PanelHeader} from 'sentry/components/panels/panelHeader'; | ||
| import {t} from 'sentry/locale'; | ||
| import {useUpdateProject} from 'sentry/utils/project/useUpdateProject'; | ||
| import {useProjectSettingsOutlet} from 'sentry/views/settings/project/projectSettingsLayout'; | ||
|
|
||
| const READ_KEY = 'sentry:preprod_snapshot_pr_comments_enabled'; | ||
| const WRITE_KEY = 'preprodSnapshotPrCommentsEnabled'; | ||
|
|
||
| export function SnapshotPrCommentsToggle() { | ||
| const {project} = useProjectSettingsOutlet(); | ||
| const {mutate: updateProject} = useUpdateProject(project); | ||
|
|
||
| const enabled = (project[WRITE_KEY] ?? project.options?.[READ_KEY]) !== false; | ||
|
|
||
| function handleToggle() { | ||
| addLoadingMessage(t('Saving...')); | ||
| updateProject( | ||
| {[WRITE_KEY]: !enabled}, | ||
| { | ||
| onSuccess: () => { | ||
| addSuccessMessage(t('PR comment settings updated')); | ||
| }, | ||
| onError: () => { | ||
| addErrorMessage(t('Failed to save changes. Please try again.')); | ||
| }, | ||
| } | ||
| ); | ||
| } | ||
|
|
||
| return ( | ||
| <Panel> | ||
| <PanelHeader>{t('Snapshots - Pull Request Comments')}</PanelHeader> | ||
| <PanelBody> | ||
| <Flex align="center" justify="between" padding="xl"> | ||
| <Stack gap="xs"> | ||
| <Text size="lg" bold> | ||
| {t('Snapshot Pull Request Comments')} | ||
| </Text> | ||
| <Text size="sm" variant="muted"> | ||
| {t('Post snapshot comparison results as comments on pull requests.')} | ||
| </Text> | ||
| </Stack> | ||
| <Switch | ||
| size="lg" | ||
| checked={enabled} | ||
| onChange={handleToggle} | ||
| aria-label={t('Toggle snapshot PR comments')} | ||
| /> | ||
| </Flex> | ||
| </PanelBody> | ||
| </Panel> | ||
| ); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New toggle component duplicates existing PR comments toggle
Low Severity
SnapshotPrCommentsToggleis a near-exact copy ofPrCommentsToggle— both are 64 lines with identical structure, logic, and component tree. The only differences are theREAD_KEY/WRITE_KEYconstants and five label strings. A single shared component accepting those as props would eliminate the duplication, reducing the risk of the two toggles drifting out of sync if the toggle logic ever needs a bug fix.Reviewed by Cursor Bugbot for commit 2b881ec. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok either way - extracting most of this to be a shared base or just leaving separate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge as is. We're still not in beta and if we combine the logic then it sets it in stone. If we want to change / add more toggles it makes it trickier.