-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(logs): Move continue scanning into full button #112351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nsdeschenes
merged 9 commits into
master
from
nd/LOGS-644/feat-logs-move-continue-scanning-into-full-button
Apr 7, 2026
+44
−31
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
47938a5
Update icon color to be accent
nsdeschenes 5be5214
Update styles for EmptyStateText
nsdeschenes a72c3c9
Update EmptyRenderer to new copy
nsdeschenes 58606a3
fix(logs): Scope empty state icon accent styling
nsdeschenes a7ab716
ref(explore): Use align prop for traces table text
nsdeschenes 3678ef9
fix(explore): Restore muted empty state text
nsdeschenes 891c2d8
Add period to empty state string
nsdeschenes b366fc5
Create explicit icon variant type, and export it
nsdeschenes 958146d
fix(explore): Render empty state text as a block element
nsdeschenes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| import type {ComponentProps, CSSProperties} from 'react'; | ||
| import type {ComponentProps} from 'react'; | ||
| import {css} from '@emotion/react'; | ||
| import styled from '@emotion/styled'; | ||
|
|
||
| import {Flex} from '@sentry/scraps/layout'; | ||
| import {Container, Flex, type Responsive} from '@sentry/scraps/layout'; | ||
| import {Text} from '@sentry/scraps/text'; | ||
|
|
||
| import {Panel} from 'sentry/components/panels/panel'; | ||
|
|
@@ -123,15 +123,23 @@ export const BreakdownPanelItem = styled(StyledPanelItem)<{highlightedSliceName: | |
| `} | ||
| `; | ||
|
|
||
| export const EmptyStateText = styled('div')<{ | ||
| export function EmptyStateText({ | ||
| children, | ||
| size, | ||
| textAlign, | ||
| }: { | ||
| children: React.ReactNode; | ||
| size: 'xl' | 'md'; | ||
| textAlign?: CSSProperties['textAlign']; | ||
| }>` | ||
| color: ${p => p.theme.tokens.content.secondary}; | ||
| font-size: ${p => p.theme.font.size[p.size]}; | ||
| padding-bottom: ${p => p.theme.space.md}; | ||
| ${p => p.textAlign && `text-align: ${p.textAlign}`}; | ||
| `; | ||
| textAlign?: Responsive<'left' | 'center' | 'right' | 'justify'>; | ||
| }) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Praise] Nice use of the design system 🙂 I like this! |
||
| return ( | ||
| <Container> | ||
| <Text as="div" size={size} align={textAlign} variant="muted"> | ||
| {children} | ||
| </Text> | ||
|
cursor[bot] marked this conversation as resolved.
|
||
| </Container> | ||
| ); | ||
| } | ||
|
nsdeschenes marked this conversation as resolved.
|
||
|
|
||
| export const EmptyValueContainer = styled('span')` | ||
| color: ${p => p.theme.tokens.content.secondary}; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.