Skip to content

fix(ai-conversations): use all projects for shared conversation links #112343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obostjancic merged 3 commits into from
Apr 8, 2026
+13 −3
Merged

fix(ai-conversations): use all projects for shared conversation links #112343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
787ea15
fix: use ALL_ACCESS_PROJECTS for shared conversation links
claude Apr 7, 2026
e3a625b
fix: also bypass environment filter for shared conversation links
claude Apr 7, 2026
8c295c2
Merge branch 'master' into ognjenbostjancic/tet-2186-project-selectio…
obostjancic Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion static/app/views/insights/pages/conversations/hooks/useConversation.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,16 +228,23 @@ describe('useConversation', () => {
expect(result.current.isLoading).toBe(false);
});

// Verify the API was called with correct timestamps (with 1-hour padding)
// Verify the API was called with correct timestamps (with 1-hour padding),
// ALL_ACCESS_PROJECTS (-1) so it searches across all projects,
// and no environment filter so it searches across all environments
expect(mockRequest).toHaveBeenCalledWith(
expect.stringContaining('/ai-conversations/conv-timestamps/'),
expect.objectContaining({
query: expect.objectContaining({
start: new Date(startTimestamp - 60 * 60 * 1000).toISOString(),
end: new Date(endTimestamp + 60 * 60 * 1000).toISOString(),
project: [-1],
}),
})
);

// Ensure environment is not included in the query when using conversation timestamps
const queryArg = mockRequest.mock.calls[0]![1]!.query;
expect(queryArg).not.toHaveProperty('environment');
});

it('falls back to span.name when span.description is empty', async () => {
Expand Down
7 changes: 5 additions & 2 deletions static/app/views/insights/pages/conversations/hooks/useConversation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {useEffect, useMemo} from 'react';

import {ALL_ACCESS_PROJECTS} from 'sentry/components/pageFilters/constants';
import {normalizeDateTimeParams} from 'sentry/components/pageFilters/parse';
import {usePageFilters} from 'sentry/components/pageFilters/usePageFilters';
import {getApiUrl} from 'sentry/utils/api/getApiUrl';
Expand Down Expand Up @@ -193,10 +194,12 @@ export function useConversation(
const hasConversationTimestamps =
conversation.startTimestamp !== undefined && conversation.endTimestamp !== undefined;

// When conversation timestamps are provided (e.g. from a shared link),
// search across all projects and environments so the conversation is found
// regardless of which project/environment the page filter is currently set to.
const queryParams = hasConversationTimestamps
? {
project: selection.projects,
environment: selection.environments,
project: [ALL_ACCESS_PROJECTS],
start: new Date(conversation.startTimestamp! - ONE_HOUR_MS).toISOString(),
end: new Date(conversation.endTimestamp! + ONE_HOUR_MS).toISOString(),
per_page: 1000,
Expand Down
Loading