Skip to content

change query to check all repos, not only the first page.#112334

Merged
rodolfoBee merged 11 commits intomasterfrom
fix-codemapping-repo-search
Apr 8, 2026
Merged

change query to check all repos, not only the first page.#112334
rodolfoBee merged 11 commits intomasterfrom
fix-codemapping-repo-search

Conversation

@rodolfoBee
Copy link
Copy Markdown
Member

fixes #112332

This changes how repos are fetched so all repos are listed for code mappings.

@rodolfoBee rodolfoBee requested a review from a team April 7, 2026 09:04
@rodolfoBee rodolfoBee requested a review from a team as a code owner April 7, 2026 09:04
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 7, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Loading state gap between infinite query page fetches
    • This was a real flicker gap and I fixed it by keeping the repos loading state true while hasNextPage remains true (unless the query is errored), so the UI waits until all pages are fetched.

Create PR

Or push these changes by commenting:

@cursor push ba8c47e560
Preview (ba8c47e560)
diff --git a/static/app/views/settings/organizationIntegrations/integrationCodeMappings.tsx b/static/app/views/settings/organizationIntegrations/integrationCodeMappings.tsx
--- a/static/app/views/settings/organizationIntegrations/integrationCodeMappings.tsx
+++ b/static/app/views/settings/organizationIntegrations/integrationCodeMappings.tsx
@@ -180,10 +180,14 @@
     data: fetchedRepos = [],
     isPending: isPendingReposQuery,
     isError: isErrorRepos,
+    hasNextPage: hasNextReposPage,
     isFetchingNextPage: isFetchingNextReposPage,
   } = repositoriesQuery;
 
-  const isPendingRepos = isPendingReposQuery || isFetchingNextReposPage;
+  const isPendingRepos =
+    isPendingReposQuery ||
+    isFetchingNextReposPage ||
+    (!!hasNextReposPage && !isErrorRepos);
 
   const pathConfigs = useMemo(() => {
     return sortBy(fetchedPathConfigs, [

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2699072. Configure here.

Comment thread static/app/views/settings/organizationIntegrations/integrationCodeMappings.tsx Outdated
@rodolfoBee
Copy link
Copy Markdown
Member Author

@cursor push ba8c47e

Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>

Applied via @cursor push command
Comment thread static/app/views/settings/organizationIntegrations/integrationCodeMappings.tsx Outdated
rodolfoBee and others added 2 commits April 7, 2026 14:40
…CodeMappings.tsx

Co-authored-by: Dominik Dorfmeister 🔮 <dominik.dorfmeister@sentry.io>
@rodolfoBee rodolfoBee merged commit f1780c1 into master Apr 8, 2026
68 checks passed
@rodolfoBee rodolfoBee deleted the fix-codemapping-repo-search branch April 8, 2026 05:55
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
fixes #112332

This changes how repos are fetched so all repos are listed for code
mappings.

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Dominik Dorfmeister 🔮 <dominik.dorfmeister@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub integration Code mapping repository search no finding all repositories

3 participants