feat(integrations): Add API driven pipeline for Slack#112315
Merged
evanpurkhiser merged 1 commit intomasterfrom Apr 7, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-integrations-add-api-driven-pipeline-for-slack
branch
from
52cf128 to
647c4e0
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 647c4e0. Configure here.
| if "oauth_data" in state: | ||
| data = state["oauth_data"] | ||
| else: | ||
| data = state["identity"]["data"] |
Contributor
There was a problem hiding this comment.
Slack API errors bypass validation causing unhandled assertion
Medium Severity
The new API pipeline path for Slack integration setup doesn't validate Slack's OAuth response body for application-level errors. Slack's oauth.v2.access endpoint returns HTTP 200 even for errors, signaling them with ok: false. This leads to an unhandled AssertionError (500) in build_integration when assert data["ok"] is hit, instead of a user-friendly error.
Reviewed by Cursor Bugbot for commit 647c4e0. Configure here.
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-integrations-add-api-driven-pipeline-for-slack
branch
from
647c4e0 to
33632d9
Compare
wedamija
approved these changes
Apr 7, 2026
Implement `get_pipeline_api_steps()` on `SlackIntegrationProvider` using a single OAuth2 step with Slack's `user_scope` parameter. Refactors `OAuth2Provider.get_pipeline_api_steps()` to expose `make_oauth_api_step()` so providers can customize step parameters (like extra_authorize_params). Updates `build_integration()` to handle both legacy `state["identity"]["data"]` and new `state["oauth_data"]` paths. Ref [VDY-42](https://linear.app/getsentry/issue/VDY-42/slack-api-driven-integration-setup)
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-integrations-add-api-driven-pipeline-for-slack
branch
from
33632d9 to
8b07e1f
Compare
leeandher
approved these changes
Apr 7, 2026
Member
leeandher
left a comment
leeandher
left a comment
There was a problem hiding this comment.
looks good! thanks for sharing the code between staging and prod slack where possible 🙏
evanpurkhiser
deleted the
evanpurkhiser/feat-integrations-add-api-driven-pipeline-for-slack
branch
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
Implement `get_pipeline_api_steps()` on `SlackIntegrationProvider` using a single OAuth2 step with Slack's `user_scope` parameter. Refactors `OAuth2Provider.get_pipeline_api_steps()` to expose `make_oauth_api_step()` so providers can customize step parameters (like extra_authorize_params). Updates `build_integration()` to handle both legacy `state["identity"]["data"]` and new `state["oauth_data"]` paths. Ref [VDY-42](https://linear.app/getsentry/issue/VDY-42/slack-api-driven-integration-setup)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
get_pipeline_api_steps()onSlackIntegrationProviderusing a single OAuth2 step with Slack'suser_scopeparameter. RefactorsOAuth2Provider.get_pipeline_api_steps()to exposemake_oauth_api_step()so providers can customize step parameters (like extra_authorize_params). Updatesbuild_integration()to handle both legacystate["identity"]["data"]and newstate["oauth_data"]paths.Ref VDY-42