fix(np): Adds attachment to Slack render type, updates metric renderer#112312
Merged
GabeVillalobos merged 10 commits intomasterfrom Apr 7, 2026
Merged
fix(np): Adds attachment to Slack render type, updates metric renderer#112312GabeVillalobos merged 10 commits intomasterfrom
GabeVillalobos merged 10 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Direct dict access on NotRequired field causes KeyError
- Updated Slack integration send_notification to use payload.get("attachments", None) so missing optional attachments no longer raises KeyError.
Or push these changes by commenting:
@cursor push a00fda5534
Preview (a00fda5534)
diff --git a/src/sentry/integrations/slack/integration.py b/src/sentry/integrations/slack/integration.py
--- a/src/sentry/integrations/slack/integration.py
+++ b/src/sentry/integrations/slack/integration.py
@@ -117,7 +117,7 @@
channel=target.resource_id,
blocks=payload["blocks"],
text=payload["text"],
- attachments=payload["attachments"],
+ attachments=payload.get("attachments", None),
unfurl_links=False,
unfurl_media=False,
)This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Contributor
Backend Test FailuresFailures on
|
Contributor
Backend Test FailuresFailures on
|
ceorourke
approved these changes
Apr 7, 2026
| serialized_blocks.append(block.to_dict()) | ||
|
|
||
| return {"blocks": serialized_blocks} | ||
| return {"blocks": serialized_blocks, "attachments": message.get("attachments", None)} |
Member
There was a problem hiding this comment.
nit: .get()'s default value is already none
Contributor
Backend Test FailuresFailures on
|
GabeVillalobos
force-pushed
the
sl_render_attach
branch
from
70d6aca to
969ec6d
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0b40258. Configure here.
| blocks=renderable["blocks"], | ||
| blocks=renderable["blocks"] if len(renderable["blocks"]) > 0 else None, | ||
| text=renderable["text"], | ||
| attachments=renderable.get("attachments"), |
Contributor
There was a problem hiding this comment.
Inconsistent unfurl flags across Slack message methods
Low Severity
This commit adds unfurl_links=False and unfurl_media=False to send_notification, send_notification_with_threading, and update_message, but omits them from send_threaded_message and send_threaded_ephemeral_message. Previously none of these methods set unfurl flags, so they were all consistent. Now threaded messages will still show link previews while non-threaded ones won't.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 0b40258. Configure here.
Member
Author
There was a problem hiding this comment.
Diverging code paths used by different callers with different expectations.
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
SlackRenderabletype to includeattachmentsas a renderable type, which allows for some legacy functionality, like colored borders on blocks. This is currently needed for feature parity with our metric alerting, and can be used by the default renderer in the future if we so choose.This PR also adds the metric alert template to our debug UI, since the rendering has been simplified significantly.