Skip to content

feat(supergroups): Add checkbox to supergroup rows for bulk selection#112301

Merged
scttcper merged 8 commits intomasterfrom
scttcper/supergroup-checkbox
Apr 8, 2026
Merged

feat(supergroups): Add checkbox to supergroup rows for bulk selection#112301
scttcper merged 8 commits intomasterfrom
scttcper/supergroup-checkbox

Conversation

@scttcper
Copy link
Copy Markdown
Member

@scttcper scttcper commented Apr 6, 2026

Add checkbox to supergroup rows for bulk issue selection, plus small QoL fixes.

  • Checkbox below the stack icon selects/deselects all member groups at once (indeterminate when partial). Hidden until hover or checked.
  • New setSelectionForIds action on the issue selection context for multi-ID dispatch.
  • Label switches from "issues matched" to bold "issues selected" when any are checked.
  • retry: false on supergroups query, it 404s when they're not found etc.
image

fixes https://linear.app/getsentry/issue/ID-1442/figuring-out-what-happens-when-selecting-a-supergroup

Supergroup rows didn't participate in the issue list's bulk selection.
This adds a checkbox below the stack icon that selects/deselects all
visible member groups at once. Shows indeterminate when only some member
groups are selected. Hidden by default, appears on row hover or when
checked — same pattern as the regular issue row checkboxes.

Adds `setSelectionForIds` to the selection context so we can set
multiple specific IDs in a single dispatch instead of toggling one at a
time.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 6, 2026
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@scttcper scttcper marked this pull request as ready for review April 7, 2026 23:45
@scttcper scttcper requested review from a team as code owners April 7, 2026 23:45
Comment thread static/app/components/stream/supergroups/supergroupRow.tsx
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 8, 2026

Comment thread .github/CODEOWNERS Outdated
/static/app/components/issues/ @getsentry/issue-workflow
/static/app/components/stackTrace/ @getsentry/issue-workflow
/static/app/components/stream/supergroupRow.tsx @getsentry/issue-detection-frontend
/static/app/components/stream/supergroupCheckbox.tsx @getsentry/issue-detection-frontend
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be time to do a components/stream/supergroups/?

Comment thread static/app/components/stream/supergroups/supergroupRow.tsx
@@ -167,6 +196,12 @@ const Wrapper = styled(PanelItem)<{highlighted: boolean}>`
min-height: 82px;
background: ${p =>
p.highlighted ? p.theme.tokens.background.secondary : 'transparent'};

&:not(:hover):not(:has(input:checked)):not(:has(input:indeterminate)) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this style is crazy, it just hides the checkbox if it's not checked or hovered?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we do this on the other rows as well

@scttcper scttcper enabled auto-merge (squash) April 8, 2026 18:34
@scttcper scttcper merged commit d0d69d2 into master Apr 8, 2026
56 checks passed
@scttcper scttcper deleted the scttcper/supergroup-checkbox branch April 8, 2026 18:41
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
…#112301)

Add checkbox to supergroup rows for bulk issue selection, plus small QoL
fixes.

- Checkbox below the stack icon selects/deselects all member groups at
once (indeterminate when partial). Hidden until hover or checked.
- New `setSelectionForIds` action on the issue selection context for
multi-ID dispatch.
- Label switches from "issues matched" to bold "issues selected" when
any are checked.
- `retry: false` on supergroups query, it 404s when they're not found
etc.

<img width="550" height="94" alt="image"
src="https://github.com/user-attachments/assets/27df4440-76e5-4376-bc3d-24000045f207"
/>

fixes
https://linear.app/getsentry/issue/ID-1442/figuring-out-what-happens-when-selecting-a-supergroup

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants