Skip to content

ref(spans): Replace useRouter usage in spans SampleList #112297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shashjar merged 1 commit into from
Apr 6, 2026
Merged

ref(spans): Replace useRouter usage in spans SampleList #112297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions static/app/views/insights/common/views/spanSummaryPage/sampleList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ import {decodeScalar} from 'sentry/utils/queryString';
import {MutableSearch} from 'sentry/utils/tokenizeSearch';
import {useLocationQuery} from 'sentry/utils/url/useLocationQuery';
import {useLocation} from 'sentry/utils/useLocation';
import {useNavigate} from 'sentry/utils/useNavigate';
import {useOrganization} from 'sentry/utils/useOrganization';
import {useProjects} from 'sentry/utils/useProjects';
import {useRouter} from 'sentry/utils/useRouter';
import {TraceItemSearchQueryBuilder} from 'sentry/views/explore/components/traceItemSearchQueryBuilder';
import {DATA_TYPE} from 'sentry/views/insights/browser/resources/settings';
import {decodeSubregions} from 'sentry/views/insights/browser/resources/utils/queryParameterDecoders/subregions';
Expand Down Expand Up @@ -82,7 +82,7 @@ export function SampleList({groupId, moduleName, transactionRoute, referrer}: Pr
},
});

const router = useRouter();
const navigate = useNavigate();
const [highlightedSpanId, setHighlightedSpanId] = useState<string | undefined>(
undefined
);
Expand All @@ -101,13 +101,16 @@ export function SampleList({groupId, moduleName, transactionRoute, referrer}: Pr
);

const handleSearch = (newSpanSearchQuery: string) => {
router.replace({
pathname: location.pathname,
query: {
...location.query,
spanSearchQuery: newSpanSearchQuery,
navigate(
{
pathname: location.pathname,
query: {
...location.query,
spanSearchQuery: newSpanSearchQuery,
},
},
});
{replace: true}
);
};

// set additional query filters from the span search bar and the `query` param
Expand Down Expand Up @@ -146,7 +149,7 @@ export function SampleList({groupId, moduleName, transactionRoute, referrer}: Pr

const handleClickSample = useCallback(
(span: SpanSample) => {
router.push(
navigate(
generateLinkToEventInTraceView({
targetId: span['transaction.span_id'],
spanId: span.span_id,
Expand All @@ -157,7 +160,7 @@ export function SampleList({groupId, moduleName, transactionRoute, referrer}: Pr
})
);
},
[organization, location, router]
[organization, location, navigate]
);

const handleMouseOverSample = useCallback(
Expand Down
Loading