Skip to content

ref(cmdk) fix panel container #112236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonasBa merged 2 commits into from
Apr 3, 2026
Merged

ref(cmdk) fix panel container #112236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72adf4c
ref(cmdk) fix panel container
JonasBa Apr 3, 2026
94ae396
ref(widgetbuilder) disconnect observer
JonasBa Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions static/app/views/dashboards/widgetBuilder/components/newWidgetBuilder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,30 @@ export function WidgetBuilderV2({
}
}, []);

const [mainContentPosition, setMainContentPosition] = useState<{
left: number;
top: number;
} | null>(null);
useEffect(() => {
const mainContentElement = document.querySelector('main');

const observer = new ResizeObserver(entries => {
for (const entry of entries) {
if (entry.target === mainContentElement) {
const rect = entry.target.getBoundingClientRect();
setMainContentPosition({top: rect.top, left: rect.left});
Comment thread
JonasBa marked this conversation as resolved.
}
}
});
if (mainContentElement) {
observer.observe(mainContentElement);
}

return () => {
observer.disconnect();
};
}, []);

const dimensions = useDimensions({elementRef: navigationElementRef});

const handleDragEnd = ({over}: any) => {
Expand Down Expand Up @@ -168,12 +192,12 @@ export function WidgetBuilderV2({
? isMediumScreen
? {
left: 0,
top: `${dimensions.height ?? 0}px`,
top: `${mainContentPosition?.top ?? 0}px`,
willChange: 'top',
}
: {
left: `${dimensions.width ?? 0}px`,
top: 0,
top: `${mainContentPosition?.top ?? 0}px`,
willChange: 'left',
}
: undefined
Expand Down
Loading