Conversation
github-actions
bot
added
the
Scope: Frontend
Replace the feature flag check with the useExperiment hook to gate the SCM onboarding flow behind the onboarding-scm-experiment experiment instead of the onboarding-scm feature flag.
The SCM onboarding flow is now gated by useExperiment instead of a feature flag. Update the test to use experiments on the org fixture and register a minimal useExperiment hook in HookStore, since gsApp's registerHooks() doesn't run in the test environment.
Now that useExperiment gates on organization.features (d389e46), the noop fallback works out of the box in tests. Remove the custom HookStore-based useTestExperiment shim and switch the fixture back to features instead of experiments.
jaydgoss
force-pushed
the
jaygoss/vdy-64-use-useexperiment-hook-to-gate-scm-onboarding-flow
branch
from
b70515f to
b247c41
Compare
Rename organizations:onboarding-scm to organizations:onboarding-scm-experiment to match the useExperiment hook now used in the onboarding component.
Abdkhan14
approved these changes
Apr 9, 2026
evanpurkhiser
approved these changes
Apr 9, 2026
jaydgoss
deleted the
jaygoss/vdy-64-use-useexperiment-hook-to-gate-scm-onboarding-flow
branch
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
…112206) Gate the SCM onboarding flow behind the `onboarding-scm-experiment` experiment using `useExperiment` instead of checking `organization.features` for the `onboarding-scm` feature flag. This allows us to run the SCM onboarding as a proper A/B experiment with exposure tracking. Updates the test to provide the experiment assignment via `OrganizationFixture` and registers a minimal `useExperiment` hook in HookStore (since gsApp's `registerHooks()` doesn't run in the test environment). Refs VDY-64
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate the SCM onboarding flow behind the
onboarding-scm-experimentexperiment usinguseExperimentinstead of checkingorganization.featuresfor theonboarding-scmfeature flag. This allows us to run the SCM onboarding as a proper A/B experiment with exposure tracking.Updates the test to provide the experiment assignment via
OrganizationFixtureand registers a minimaluseExperimenthook in HookStore (since gsApp'sregisterHooks()doesn't run in the test environment).Refs VDY-64