feat(snuba): add a metric in query_trace_data to see what spans report span.status "ok" but have an associated error#112090
Merged
constantinius merged 4 commits intomasterfrom Apr 9, 2026
Conversation
…ort `span.status` "ok" but have an associated error
Contributor
Backend Test FailuresFailures on
|
vgrozdanic
approved these changes
Apr 2, 2026
…add-metric-to-get-incoherent-spans
vgrozdanic
approved these changes
Apr 9, 2026
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
…ort `span.status` "ok" but have an associated error (#112090) Emit a metric for cases when we detect a span with status "ok" but errors associated. This queries the additional fields "span.status", "origin", "sdk.version" which we use as tags in the metric. Contributes to https://linear.app/getsentry/issue/TET-2102/detect-spanstatus-inconsistencies-and-report-to-sdk-teams
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit a metric for cases when we detect a span with status "ok" but errors associated.
This queries the additional fields "span.status", "origin", "sdk.version" which we use as tags in the metric.
Contributes to https://linear.app/getsentry/issue/TET-2102/detect-spanstatus-inconsistencies-and-report-to-sdk-teams