Skip to content

feat(symbolicator): pass objectstore token to symbolicator#112058

Merged
jan-auer merged 4 commits intomasterfrom
matth/symbolicator-pass-token
Apr 2, 2026
Merged

feat(symbolicator): pass objectstore token to symbolicator#112058
jan-auer merged 4 commits intomasterfrom
matth/symbolicator-pass-token

Conversation

@matt-codecov
Copy link
Copy Markdown
Contributor

@matt-codecov matt-codecov commented Apr 1, 2026

pass an objectstore token to symbolicator alongside minidump/applecrashreport attachment URLs

NOTE: token expiry time is set in the global client and shared across usecases/sessions. the default value is 60s.

Requires getsentry/objectstore#416 (and a client version bump)
Requires getsentry/symbolicator#1915
Ref FS-329

@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 1, 2026

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Backend Test Failures

Failures on 5513e53 in this run:

tests/sentry/ingest/ingest_consumer/test_ingest_consumer_processing.py::test_process_stored_attachmentlog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/ingest/ingest_consumer/test_ingest_consumer_processing.py:518: in test_process_stored_attachment
    assert thread_name == "sentry-http"
E   AssertionError: assert None == 'sentry-http'
tests/symbolicator/test_minidump_full.py::SymbolicatorMinidumpIntegrationTest::test_reprocessinglog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/symbolicator/test_minidump_full.py:189: in test_reprocessing
    candidates = new_event.data["debug_meta"]["images"][0]["candidates"]
src/sentry/db/models/fields/node.py:54: in __getitem__
    return self.data[key]
src/sentry/models/event.py:56: in __getitem__
    return self.data[k]
E   KeyError: 'debug_meta'

@jan-auer jan-auer marked this pull request as ready for review April 2, 2026 11:19
@jan-auer jan-auer requested review from a team as code owners April 2, 2026 11:19
The storage token was minted once before entering the retry loop in
_process. On TaskIdNotFound or ServiceUnavailable the task is
resubmitted with the same token, which may have expired by then.

Add a kwargs_cb parameter to _process that is called on every new task
submission and merged over the static kwargs. The objectstore callers
use this to mint a fresh token each time instead of reusing the
original one.
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@jan-auer jan-auer enabled auto-merge (squash) April 2, 2026 14:54
@jan-auer jan-auer merged commit cf3f63b into master Apr 2, 2026
116 of 118 checks passed
@jan-auer jan-auer deleted the matth/symbolicator-pass-token branch April 2, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants