feat(symbolicator): pass objectstore token to symbolicator#112058
Merged
feat(symbolicator): pass objectstore token to symbolicator#112058
Conversation
Contributor
Backend Test FailuresFailures on
|
The storage token was minted once before entering the retry loop in _process. On TaskIdNotFound or ServiceUnavailable the task is resubmitted with the same token, which may have expired by then. Add a kwargs_cb parameter to _process that is called on every new task submission and merged over the static kwargs. The objectstore callers use this to mint a fresh token each time instead of reusing the original one.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
loewenheim
reviewed
Apr 2, 2026
loewenheim
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

pass an objectstore token to symbolicator alongside minidump/applecrashreport attachment URLs
NOTE: token expiry time is set in the global client and shared across usecases/sessions. the default value is 60s.
Requires getsentry/objectstore#416 (and a client version bump)
Requires getsentry/symbolicator#1915
Ref FS-329