fix(test): stabilize flaky TimeSince timezone tooltip test#111928
Closed
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Closed
fix(test): stabilize flaky TimeSince timezone tooltip test#111928JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
JoshuaKGoldberg
added
the
Frontend: Rerun Flaky Tests
github-actions
bot
added
the
Scope: Frontend
JoshuaKGoldberg
force-pushed
the
fix/flaky-time-since-spec
branch
from
30ff8c6 to
6b2cd3d
Compare
JoshuaKGoldberg
commented
Mar 31, 2026
| await waitFor(() => { | ||
| expect(screen.getByText(/EST/)).toBeInTheDocument(); | ||
| }); | ||
| expect(await screen.findByText(/EST/)).toBeInTheDocument(); |
Member
Author
There was a problem hiding this comment.
[Explanation] Cursor made this change. They're roughly equivalent, so I do prefer the updated version for simplicity.
For fun, I had Cursor also whip up a lint rule to enforce this: #111990
TkDodo
approved these changes
Apr 2, 2026
JoshuaKGoldberg
force-pushed
the
fix/flaky-time-since-spec
branch
from
6b2cd3d to
9269297
Compare
Increase waitFor timeout to 3000ms for the tooltip text assertion. The tooltip has a render delay that can exceed waitFor's default 1000ms timeout under CI load. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> Made-with: Cursor
Member
Author
|
Ok this isn't fair. I rebased off 
|
scttcper
approved these changes
Apr 2, 2026
Member
Author
|
Superseded by #112196 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilizes the
TimeSince > respects timezone in tooltiptest by eliminating the tooltip open delay as a source of flakiness.The test hovers a
<time>element and asserts a tooltip containing "EST" appears. TheTooltipcomponent has a default 50msOPEN_DELAYthat, combined with React render time under CI load, could cause the assertion to fail intermittently.This gets around the delay by passing an explicit
tooltipProps={{delay: 0}}, making the tooltip appear much more quickly.Note that CI Jest tests are failing because the Frontend: Rerun Flaky TestsKnown flaky tests should be run many times, just to be safe.
label is causing other, still-flaky tests to be run.
Fixes ENG-7211
Made with Cursor