Skip to content

fix(test): stabilize flaky SpanEvidencePreview spec#111914

Closed
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
fix/flaky-span-evidence-preview-v3
Closed

fix(test): stabilize flaky SpanEvidencePreview spec#111914
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
fix/flaky-span-evidence-preview-v3

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 31, 2026

Extract shared defaultProps, clear mock responses in beforeEach, use userEvent.click + findByRole('listbox') before typing to ensure the combobox is ready, and add terminal waitFor calls to flush pending React state updates.

Fixes ENG-7201

Made with Cursor

@JoshuaKGoldberg JoshuaKGoldberg added Scope: Frontend Automatically applied to PRs that change frontend components Frontend: Rerun Flaky Tests Known flaky tests should be run many times, just to be safe. labels Mar 31, 2026
@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(test): Fix flaky SpanEvidencePreview error state test fix(test): Fix flaky SpanEvidencePreview and ResultsSearchQueryBuilder tests Mar 31, 2026
@linear-code
Copy link
Copy Markdown

linear-code bot commented Mar 31, 2026

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(test): Fix flaky SpanEvidencePreview and ResultsSearchQueryBuilder tests fix(test): stabilize flaky SpanEvidencePreview and ResultsSearchQueryBuilder tests Mar 31, 2026
@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(test): stabilize flaky SpanEvidencePreview and ResultsSearchQueryBuilder tests fix(test): stabilize flaky ResultsSearchQueryBuilder spec Mar 31, 2026
@JoshuaKGoldberg JoshuaKGoldberg force-pushed the fix/flaky-span-evidence-preview-v3 branch from 820dba3 to 13a9986 Compare March 31, 2026 18:04
@JoshuaKGoldberg JoshuaKGoldberg changed the base branch from fix/flaky-test-rerun-infra to master April 7, 2026 14:09
@JoshuaKGoldberg JoshuaKGoldberg removed the Frontend: Rerun Flaky Tests Known flaky tests should be run many times, just to be safe. label Apr 7, 2026
@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(test): stabilize flaky ResultsSearchQueryBuilder spec fix(test): stabilize flaky SpanEvidencePreview spec Apr 8, 2026
@JoshuaKGoldberg JoshuaKGoldberg added the Frontend: Rerun Flaky Tests Known flaky tests should be run many times, just to be safe. label Apr 8, 2026
Use waitFor with a longer timeout for the error text assertion.
The hovercard has a render delay and useApiQuery may retry failed
requests, causing findByText to time out under CI load.

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend: Rerun Flaky Tests Known flaky tests should be run many times, just to be safe. Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant