fix(test): stabilize flaky MetricsTabContent sidebar toggle test#111909
Closed
JoshuaKGoldberg wants to merge 3 commits intomasterfrom
Closed
fix(test): stabilize flaky MetricsTabContent sidebar toggle test#111909JoshuaKGoldberg wants to merge 3 commits intomasterfrom
JoshuaKGoldberg wants to merge 3 commits intomasterfrom
Conversation
JoshuaKGoldberg
added
Scope: Frontend
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
changed the base branch from
fix/flaky-test-rerun-infra
to
master
JoshuaKGoldberg
removed
the
Frontend: Rerun Flaky Tests
JoshuaKGoldberg
force-pushed
the
fix/flaky-metrics-tab-spec-v2
branch
from
9f36ce9 to
b294b49
Compare
JoshuaKGoldberg
force-pushed
the
fix/flaky-metrics-tab-spec-v2
branch
from
b294b49 to
453e4da
Compare
Wait for the SearchQueryBuilderCombobox inside the re-expanded sidebar to finish initialising. Without this, its async state updates fire after the test ends and trigger an act() warning that jest-fail-on-console catches, causing flaky failures (4 occurrences in the last 30 days). Co-Authored-By: Claude Sonnet 4 <noreply@example.com> Made-with: Cursor
JoshuaKGoldberg
force-pushed
the
fix/flaky-metrics-tab-spec-v2
branch
from
453e4da to
1f81cb4
Compare
JoshuaKGoldberg
added
the
Frontend: Rerun Flaky Tests
nsdeschenes
approved these changes
Apr 13, 2026
Comment on lines
737
to
739
| await waitFor(() => { | ||
| expect(screen.getAllByTestId('metric-toolbar')).toHaveLength(1); | ||
| expect(within(metricToolbar).getByRole('combobox')).toBeInTheDocument(); | ||
| }); |
Contributor
There was a problem hiding this comment.
Suggested change
| await waitFor(() => { | |
| expect(screen.getAllByTestId('metric-toolbar')).toHaveLength(1); | |
| expect(within(metricToolbar).getByRole('combobox')).toBeInTheDocument(); | |
| }); | |
| const combobox = await within(metricToolbar).findByRole('combobox') | |
| expect(combobox).toBeInTheDocument(); |
Member
Author
|
This test was deleted in #111920. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
toggles the query builder sidebar with the expand controlcollapses and re-expands the sidebar, but only waited for the toolbartestIdto reappear. TheSearchQueryBuilderComboboxinside the toolbar was still running async initialization, so its state updates leaked past the test boundary. This adds an explicit wait afterwards to let that initialization finish.Fixes ENG-7202
Made with Cursor