fix(test): stabilize flaky EventReplay inline onboarding test#111902
Merged
JoshuaKGoldberg merged 1 commit intomasterfrom Apr 7, 2026
Merged
fix(test): stabilize flaky EventReplay inline onboarding test#111902JoshuaKGoldberg merged 1 commit intomasterfrom
JoshuaKGoldberg merged 1 commit intomasterfrom
Conversation
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Contributor
|
🚧 Skipped: PR exceeds review size limit. Please split into smaller PRs and re-run. |
Made-with: Cursor
96cf5c0 to
b96db76
Compare
scttcper
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ReplayInlineOnboardingPanelcomponent is loaded viaReact.lazy(), creating an async code-splitting boundary. Inside that lazy-loaded component,usePromptcallsuseApiQuery(React Query), adding another async data-fetching boundary. The combination of these two async layers occasionally exceeded thefindByTextdefault timeout in CI, causing the test to flake.This PR mocks the
replayInlineOnboardingPanelmodule (a pattern already used forreplayClipPreview) and asserts on adata-test-idinstead of the rendered text.Fixes REPLAY-879
Note that CI Jest tests are failing because the Frontend: Rerun Flaky TestsKnown flaky tests should be run many times, just to be safe.
label is causing other, still-flaky tests to be run.No longer applicable now that this is targetingmasterand #111860 is not yet merged.Made with Cursor