Skip to content

fix(test): stabilize flaky EventReplay inline onboarding test#111902

Merged
JoshuaKGoldberg merged 1 commit intomasterfrom
fix/flaky-event-replay-spec
Apr 7, 2026
Merged

fix(test): stabilize flaky EventReplay inline onboarding test#111902
JoshuaKGoldberg merged 1 commit intomasterfrom
fix/flaky-event-replay-spec

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 31, 2026

The ReplayInlineOnboardingPanel component is loaded via React.lazy(), creating an async code-splitting boundary. Inside that lazy-loaded component, usePrompt calls useApiQuery (React Query), adding another async data-fetching boundary. The combination of these two async layers occasionally exceeded the findByText default timeout in CI, causing the test to flake.

This PR mocks the replayInlineOnboardingPanel module (a pattern already used for replayClipPreview) and asserts on a data-test-id instead of the rendered text.

Fixes REPLAY-879

Note that CI Jest tests are failing because the Frontend: Rerun Flaky Tests Known flaky tests should be run many times, just to be safe. label is causing other, still-flaky tests to be run. No longer applicable now that this is targeting master and #111860 is not yet merged.

Made with Cursor

@JoshuaKGoldberg JoshuaKGoldberg added Scope: Frontend Automatically applied to PRs that change frontend components Frontend: Rerun Flaky Tests Known flaky tests should be run many times, just to be safe. labels Mar 31, 2026
@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(test): Fix flaky EventReplay inline onboarding test fix(test): stabilize flaky EventReplay inline onboarding test Mar 31, 2026
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review March 31, 2026 17:55
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft March 31, 2026 17:56
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 1, 2026

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 1, 2026 16:39
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team April 1, 2026 16:41
@JoshuaKGoldberg JoshuaKGoldberg requested review from a team as code owners April 7, 2026 14:07
@JoshuaKGoldberg JoshuaKGoldberg requested review from a team as code owners April 7, 2026 14:07
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft April 7, 2026 14:09
@JoshuaKGoldberg JoshuaKGoldberg changed the base branch from fix/flaky-test-rerun-infra to master April 7, 2026 14:09
@sentry
Copy link
Copy Markdown
Contributor

sentry bot commented Apr 7, 2026

🚧 Skipped: PR exceeds review size limit.

Please split into smaller PRs and re-run.
Reference ID: 12937490

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the fix/flaky-event-replay-spec branch from 96cf5c0 to b96db76 Compare April 7, 2026 14:14
@JoshuaKGoldberg JoshuaKGoldberg removed Scope: Backend Automatically applied to PRs that change backend components Frontend: Rerun Flaky Tests Known flaky tests should be run many times, just to be safe. labels Apr 7, 2026
@JoshuaKGoldberg JoshuaKGoldberg removed request for a team April 7, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants