Skip to content

fix(test): stabilize flaky allMonitors select all query results test #111901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaKGoldberg merged 2 commits into from
Apr 13, 2026
Merged

fix(test): stabilize flaky allMonitors select all query results test #111901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5556911
fix(test): Fix flaky customerDetails billing permissions test
JoshuaKGoldberg Mar 31, 2026
65b3a5c
Merge branch 'master' into fix/flaky-customer-details-spec
JoshuaKGoldberg Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions static/app/views/detectors/list/allMonitors.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ describe('DetectorsList', () => {

const testUser = UserFixture({id: '2', email: 'test@example.com'});
// Mock the filtered search results - this will be used when search is applied
const filteredDetectors = Array.from({length: 20}, (_, i) =>
const filteredDetectors = Array.from({length: 3}, (_, i) =>
MetricDetectorFixture({
id: `filtered-${i}`,
name: `Assigned Detector ${i + 1}`,
Expand All @@ -509,7 +509,7 @@ describe('DetectorsList', () => {
url: '/organizations/org-slug/detectors/',
body: filteredDetectors,
headers: {
'X-Hits': '50',
'X-Hits': '10',
},
match: [
MockApiClient.matchQuery({
Expand Down Expand Up @@ -540,9 +540,9 @@ describe('DetectorsList', () => {
await userEvent.click(masterCheckbox);

// Should show alert with option to select all query results
expect(screen.getByText(/20 monitors on this page selected/)).toBeInTheDocument();
expect(screen.getByText(/3 monitors on this page selected/)).toBeInTheDocument();
const selectAllForQuery = screen.getByRole('button', {
name: /Select all 50 monitors that match this search query/,
name: /Select all 10 monitors that match this search query/,
});
await userEvent.click(selectAllForQuery);

Expand Down
Loading