Skip to content

fix(performance): Restore feature parity on EAP Sampled Events tab #111891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjq merged 28 commits into from
Apr 7, 2026
Merged

fix(performance): Restore feature parity on EAP Sampled Events tab #111891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a1cea10
ref(perf): Remove category filter from EAP sampled events table
mjq Mar 24, 2026
b80a168
ref(perf): Decouple OverviewSpansTable from shared segment spans query
mjq Mar 25, 2026
1d072c4
feat(perf): Enable column sorting in EAP sampled events table
mjq Mar 25, 2026
23b2c52
ref(perf): Conditionally show Replay column in EAP sampled events table
mjq Mar 25, 2026
552ebf7
feat(perf): Link trace ID to trace details in EAP sampled events table
mjq Mar 25, 2026
e7d8b99
feat(perf): Add HTTP Method column to EAP sampled events table
mjq Mar 25, 2026
82b552e
feat(perf): Add User column to EAP sampled events table
mjq Mar 26, 2026
84ac068
ref(perf): Reorder columns in EAP sampled events table
mjq Mar 26, 2026
2250974
add operation duration column
mjq Mar 26, 2026
7f1a499
feat(perf): Add Open in Explore button to EAP sampled events table
mjq Mar 26, 2026
aac9e56
feat(perf): Add Percentile dropdown to EAP sampled events table
mjq Mar 27, 2026
a4e2bc1
fix(perf): Clamp negative otherPercentage in operation duration break…
mjq Mar 27, 2026
4a40b2c
ref(perf): Rename OverviewSpansTable to SampledEventsTable
mjq Mar 27, 2026
5dc5600
fix(perf): Fix project lookup when multiple projects selected
mjq Mar 27, 2026
6c11031
fix(perf): Preserve date context in trace links from sampled events t…
mjq Mar 27, 2026
724e760
ref(performance): De-slop EAP version of Sampled Events
mjq Mar 30, 2026
2b574d5
move percentile value mapping out of utils
mjq Mar 31, 2026
35fa3af
make request.method column conditional on project type
mjq Mar 31, 2026
7d86a1f
add test confirming switch via eap flag
mjq Mar 31, 2026
e67ed32
add smoke tests for new EAP components
mjq Mar 31, 2026
28be701
fix bug when loading page with percentile filter selected
mjq Mar 31, 2026
d40b310
remove duplicated CSS
mjq Mar 31, 2026
61f54e5
review feedback
mjq Apr 7, 2026
dfa0da9
Merge branch 'master' into mjq/eap-sampled-events-papercuts
mjq Apr 7, 2026
83ea1e2
fix missing percentileValues
mjq Apr 7, 2026
da7bcc4
remove dead prop
mjq Apr 7, 2026
1eac8fb
use Grid component
mjq Apr 7, 2026
2833a05
:hammer_and_wrench: apply pre-commit fixes
getsantry[bot] Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions static/app/views/insights/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,13 @@ export enum SpanFields {
AI_TOTAL_COST = 'ai.total_cost',
AI_TOTAL_TOKENS_USED = 'ai.total_tokens.used',

// Span Operation Breakdown fields
SPANS_BROWSER = 'spans.browser',
SPANS_DB = 'spans.db',
SPANS_HTTP = 'spans.http',
SPANS_RESOURCE = 'spans.resource',
SPANS_UI = 'spans.ui',

// DB fields
DB_SYSTEM = 'db.system', // TODO: this is a duplicate of `SPAN_SYSTEM`

Expand Down
217 changes: 0 additions & 217 deletions static/app/views/performance/eap/overviewSpansTable.tsx
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion static/app/views/performance/eap/segmentSpansTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export function SegmentSpansTable({
const {projects} = useProjects();
const navigate = useNavigate();

const projectSlug = projects.find(p => p.id === `${eventView.project}`)?.slug;
const projectSlug = projects.find(p => p.id === String(eventView.project[0]))?.slug;
const spanCategory = decodeScalar(location.query?.[SpanFields.SPAN_CATEGORY]);
const {selected, options} = getEAPSegmentSpansListSort(location, spanCategory);

Expand Down
Loading
Loading