fix(seer): Align project grouping record deletion with Seer API#111756
Merged
Mihir-Mavalankar merged 1 commit intomasterfrom Mar 27, 2026
Merged
fix(seer): Align project grouping record deletion with Seer API#111756Mihir-Mavalankar merged 1 commit intomasterfrom
Mihir-Mavalankar merged 1 commit intomasterfrom
Conversation
kddubey
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://sentry.sentry.io/issues/5865067343/?project=1&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=7d
This PR addresses the
seer.delete_grouping_records.project.failureerrors, which saw a significant spike recently.The root cause was a mismatch in how Sentry was calling the Seer API endpoint for deleting grouping records by project (
/v0/issues/similar-issues/grouping-record/delete).Specifically, two issues were identified:
POSTrequest, while the Seer endpoint was defined as aGET.project_idin the request body, but Seer expected it as a path parameter (e.g.,/v0/issues/similar-issues/grouping-record/delete/{project_id}).This change updates the
make_delete_grouping_records_by_project_requestfunction insrc/sentry/seer/signed_seer_api.pyto:GETHTTP method.project_idincluded as a path parameter.GETrequests typically do not carry a body.This fix ensures that Sentry correctly communicates with the Seer service for project grouping record deletions, resolving the 404 errors and allowing these background tasks to complete successfully.