Skip to content

fix(seer): Align project grouping record deletion with Seer API#111756

Merged
Mihir-Mavalankar merged 1 commit intomasterfrom
seer/fix/seer-project-grouping-delete-api
Mar 27, 2026
Merged

fix(seer): Align project grouping record deletion with Seer API#111756
Mihir-Mavalankar merged 1 commit intomasterfrom
seer/fix/seer-project-grouping-delete-api

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Mar 27, 2026

Issue: https://sentry.sentry.io/issues/5865067343/?project=1&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=7d
This PR addresses the seer.delete_grouping_records.project.failure errors, which saw a significant spike recently.

The root cause was a mismatch in how Sentry was calling the Seer API endpoint for deleting grouping records by project (/v0/issues/similar-issues/grouping-record/delete).

Specifically, two issues were identified:

  1. Incorrect HTTP Method: Sentry was sending a POST request, while the Seer endpoint was defined as a GET.
  2. Incorrect Parameter Location: Sentry was sending the project_id in the request body, but Seer expected it as a path parameter (e.g., /v0/issues/similar-issues/grouping-record/delete/{project_id}).

This change updates the make_delete_grouping_records_by_project_request function in src/sentry/seer/signed_seer_api.py to:

  • Use the GET HTTP method.
  • Construct the URL with the project_id included as a path parameter.
  • Send an empty body, as GET requests typically do not carry a body.

This fix ensures that Sentry correctly communicates with the Seer service for project grouping record deletions, resolving the 404 errors and allowing these background tasks to complete successfully.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 27, 2026
@Mihir-Mavalankar Mihir-Mavalankar self-assigned this Mar 27, 2026
@Mihir-Mavalankar Mihir-Mavalankar marked this pull request as ready for review March 27, 2026 20:53
@Mihir-Mavalankar Mihir-Mavalankar requested a review from a team as a code owner March 27, 2026 20:53
@Mihir-Mavalankar Mihir-Mavalankar added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Mar 27, 2026
@Mihir-Mavalankar Mihir-Mavalankar merged commit 655cefc into master Mar 27, 2026
81 of 96 checks passed
@Mihir-Mavalankar Mihir-Mavalankar deleted the seer/fix/seer-project-grouping-delete-api branch March 27, 2026 21:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants