Skip to content

chore(search): Add validation feature flag#111752

Merged
nsdeschenes merged 1 commit intomasterfrom
nd/EXP-857/chore-search-add-validation-feature-flag
Mar 30, 2026
Merged

chore(search): Add validation feature flag#111752
nsdeschenes merged 1 commit intomasterfrom
nd/EXP-857/chore-search-add-validation-feature-flag

Conversation

@nsdeschenes
Copy link
Copy Markdown
Contributor

Adding a flag in so that we can initially restrict calling the validation before fully rolling this feature out.

Ticket: EXP-857

@linear-code
Copy link
Copy Markdown

linear-code bot commented Mar 27, 2026

EXP-857 Add feature flag

@nsdeschenes nsdeschenes marked this pull request as ready for review March 27, 2026 20:15
@nsdeschenes nsdeschenes requested a review from a team March 27, 2026 20:15
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 27, 2026
@nsdeschenes nsdeschenes merged commit bfb775e into master Mar 30, 2026
85 of 86 checks passed
@nsdeschenes nsdeschenes deleted the nd/EXP-857/chore-search-add-validation-feature-flag branch March 30, 2026 14:06
nsdeschenes added a commit that referenced this pull request Mar 30, 2026
The goal of this PR is to validate the filter keys on any trace item
based search query builder. To do this we've introduced a new API
endpoint that accepts in a list of attributes and checks to see if they
exist and are valid.

We trigger this with a useQuery that runs on mount, and whenever the
user modifies the query. We also have guards in place to ignore running
the validation if the user is just modifying the filter values as those
don't need to be validated, reducing the amount of calls we make.

Validation is currently gated behind this flag:
#111752

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants