ref(spans): Cleanup merge payloads code and distributed payloads migration flags#111746
Merged
ref(spans): Cleanup merge payloads code and distributed payloads migration flags#111746
Conversation
github-actions
bot
added
the
Scope: Backend
evanh
approved these changes
Mar 30, 2026
Member
evanh
left a comment
evanh
left a comment
There was a problem hiding this comment.
Nice to see this all simplified again.
fpacifici
reviewed
Mar 30, 2026
Comment on lines
-3314
to
-3332
| register( | ||
| "spans.buffer.write-distributed-payloads", | ||
| default=False, | ||
| flags=FLAG_PRIORITIZE_DISK | FLAG_AUTOMATOR_MODIFIABLE, | ||
| ) | ||
| # Switch flusher to read from distributed keys instead of merged. | ||
| register( | ||
| "spans.buffer.read-distributed-payloads", | ||
| default=False, | ||
| flags=FLAG_PRIORITIZE_DISK | FLAG_AUTOMATOR_MODIFIABLE, | ||
| ) | ||
| # Set to False to stop writing merged keys and skip set merges. | ||
| # Disable after read-distributed-payloads is stable. Rollback: re-enable | ||
| # this flag to resume merged writes before reverting read-distributed-payloads. | ||
| register( | ||
| "spans.buffer.write-merged-payloads", | ||
| default=True, | ||
| flags=FLAG_PRIORITIZE_DISK | FLAG_AUTOMATOR_MODIFIABLE, | ||
| ) |
Contributor
There was a problem hiding this comment.
You have to unset these in options automator before removing it from the codebase.
You can do one of these:
- if the default value is already matching what you see in options automator, just send a PR to remove from options automator first, then you can sedn this PR as it is
- if the default value is not what you have in options automator: either change the default value here first, then options automator then this; otherwise leave the option registered here, remove hte code in the rest of the pr, then remove from options automator and the option from here.
| redis_ttl = options.get("spans.buffer.redis-ttl") | ||
| timeout = options.get("spans.buffer.timeout") | ||
| root_timeout = options.get("spans.buffer.root-timeout") | ||
| max_segment_bytes = options.get("spans.buffer.max-segment-bytes") |
Contributor
There was a problem hiding this comment.
Why is this being removed? We still enforce a maximum segment size otherwise the produced segments may be too large for Kafka downstream.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs STREAM-799