ref(cells): Rename regions to cells in users models#111741
Conversation
Also adds TODO comments and details about the user endpoints that need to be changed: - UserRegions should be deprecated - UserOrganizationsEndpoint needs to move to control
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| # TODO(cells): Non-routable by Synapse (no org slug in URL). Fix by moving to | ||
| # @control_silo_endpoint and querying OrganizationMemberMapping + OrganizationMapping. |
There was a problem hiding this comment.
We would also need to do a fanout to each cell that the user has membership in. This endpoint is doing a full details response which serializes projects and teams. We could add an opt-in flow to use data that is control only (like the new org list endpoint) so that we aren't stuck with fanout for all requests. I made a linear ticket for this TODO.
| # TODO(cells): Deprecate once organization listing is moved to control and the frontend | ||
| # no longer needs locality URLs for client-side fan-out. |
There was a problem hiding this comment.
We'll have to see if there is external usage of this endpoint. It doesn't seem too complicated to keep this endpoint around if it is being used, but I agree it will be kind of redundant.
3 participants
Also adds TODO comments and details about the user endpoints that need to be changed: