Skip to content

feat(ACI): Release rule stats and group history wfe endpoints#111737

Merged
ceorourke merged 1 commit intomasterfrom
ceorourke/rulestats-grouphistory-flag
Mar 27, 2026
Merged

feat(ACI): Release rule stats and group history wfe endpoints#111737
ceorourke merged 1 commit intomasterfrom
ceorourke/rulestats-grouphistory-flag

Conversation

@ceorourke
Copy link
Copy Markdown
Member

Add a flag to release the rule stats and group history workflow engine versions of the endpoints. These complement the ProjectRuleDetailsEndpoint which is about to be released to GA as they provide additional context for rendering the page.

@ceorourke ceorourke requested review from a team as code owners March 27, 2026 18:55
@ceorourke ceorourke requested a review from a team March 27, 2026 18:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 27, 2026
@kcons kcons self-requested a review March 27, 2026 19:01
)

@with_feature("organizations:workflow-engine-rule-serializers")
@with_feature("organizations:workflow-engine-projectrulegroupstats-get")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really need both flags, I wonder if it implies we do that we use them. As is, this isn't specifically testing either. I'd say our preferred pattern here is probably use the big flag by default, but have a test that ensures that the targeted flag works.

Not blocking, just thinking. we can do a pass.

@ceorourke ceorourke merged commit bc6205d into master Mar 27, 2026
64 of 65 checks passed
@ceorourke ceorourke deleted the ceorourke/rulestats-grouphistory-flag branch March 27, 2026 22:30
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants