fix(performance): Restore feature parity on EAP Sampled Events tab by mjq · Pull Request #111731 · getsentry/sentry

mjq · 2026-03-27T18:13:28Z

This chunky PR brings the Transaction Summary > Sampled Events tab up to feature parity with the pre-EAP version (with a single exception).

What's fixed:

You can sort columns
Display of the Replay column is now conditional
The Trace ID is now a link to the trace waterfall
The HTTP method, user, and operation breakdown columns are back
You can now Open In Explore (like the old Open In Discover)
Filtering by percentile is back

What's different from the pre-EAP Sampled Events tab:

The span category filter is no longer on the page. I don't know what the behaviour is supposed to be because it was broken and inconsistent on the pre-EAP version. If we ever spec it out we can bring it back.

We're still split between switching on EAP conditionally inside components, and duplicating into new - all this goes away as soon as the GA for this is stable.

Each commit is pretty self-contained, if that helps for reviewing - if it's still too big I'm happy to break it up.

Fixes DAIN-1401.

linear-code · 2026-03-27T18:13:31Z

DAIN-1401 Restore feature parity for Sampled Events tab of Transaction Summary

The SpanCategoryFilter dropdown on the sampled events tab had no effect since the OverviewSpansTable does not consume the span.category URL param. Remove it and adjust the grid layout so the search bar fills the available space in the EAP path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Replace useSegmentSpansQuery with a direct useSpans call and define inline fields, column types, and column order. This decouples the overview events table from segmentSpansTable so each can evolve independently. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Wire up URL-based sort state for the OverviewSpansTable so that span.duration and timestamp columns are sortable, matching the non-EAP EventsTable behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Match the non-EAP behavior by only showing the Replay column when the organization has the session-replay feature flag and the project platform supports replays. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Wrap the trace ID column in a link to the trace details view, matching the existing behavior in the transaction events table. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Display request.method as a column before duration in the overview spans table, making it easier to distinguish between different HTTP methods at a glance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Display user.display (derived from user.username, user.email, user.ip, or user.id) as a column in the overview spans table. Co-Authored-By: Claude Opus 4.6 <noreply@example.com>

Move Span ID to the first column and Trace ID after Total Duration for a more natural reading order: Span ID, User, HTTP Method, Total Duration, Trace ID, Timestamp, Replay, Profile. Co-Authored-By: Claude Opus 4.6 <noreply@example.com>

Add an "Open in Explore" button to the filter bar when the EAP transaction summary is active, mirroring the "Open in Discover" button shown for non-EAP. The button links to the Explore Traces page preserving the current query, page filters, and sort. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Enable the Percentile filter (p50/p75/p95/p99/p100) for EAP mode, which was previously hidden. Fetches percentile thresholds via useSpans with p50(span.duration) through p100(span.duration), applies a span.duration filter to the table and count queries, and carries the filter into the Open in Explore URL. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…down The `otherPercentage` value could go negative due to floating-point drift, producing an invalid negative CSS width. Use Math.max to clamp it to zero. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Rename to match the UI label for this table. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

eventView.project is a number array. Using a template literal on the whole array produces "1,2" with multiple projects, which never matches any project ID. Use the first element instead, matching the pattern in useEventViewProject. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…able Passing an empty dateSelection to getTraceDetailsUrl caused the current page's date filter params (statsPeriod, start, end) to be overwritten with undefined. Use normalizeDateTimeParams to extract the date selection from the URL query params instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mjq · 2026-03-31T15:56:33Z

@cursor review

mjq · 2026-03-31T15:56:39Z

@sentry review

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-03-31T16:02:47Z

+      pageFilters: selection,
+    },
+    'api.insights.segment-spans-table'
+  );


Table queries fire without duration filter during loading

Low Severity

When a non-P100 percentile filter is active, useMaxDuration returns maxDuration: 0 while loading (because mapEAPPercentileValues([]) defaults all values to 0). Since 0 fails the maxDuration > 0 check, both the count and table useSpans queries fire immediately without any duration filter. When the percentile query completes, maxDuration updates and both queries re-fire with the correct filter — making the first pair of API calls wasted. Passing something like enabled: !isMaxDurationLoading to the table's useSpans calls (or returning undefined instead of 0 from mapEAPPercentileValues during loading) would prevent the unnecessary requests.

Additional Locations (1)

static/app/views/performance/transactionSummary/transactionEvents/eapSampledEventsTab.tsx#L314-L341

mjq · 2026-03-31T16:09:09Z

This PR has gone through too many iterations (binary searching where my tsc OOM in CI was introduced, for one thing...). Now that I'm ready for review, starting again with a clean slate.

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 27, 2026

mjq changed the title ~~Mjq/eap sampled events papercuts~~ fix(performance): Restore feature parity on EAP Sampled Events tab Mar 27, 2026

sentry bot reviewed Mar 27, 2026

View reviewed changes

Comment thread static/app/views/performance/eap/sampledEventsTable.tsx Outdated

This comment was marked as resolved.

Sign in to view

vercel bot deployed to Preview March 27, 2026 18:33 View deployment

This comment was marked as resolved.

Sign in to view

mjq and others added 8 commits March 29, 2026 21:23

feat(perf): Enable column sorting in EAP sampled events table

d1d8306

Wire up URL-based sort state for the OverviewSpansTable so that span.duration and timestamp columns are sortable, matching the non-EAP EventsTable behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat(perf): Link trace ID to trace details in EAP sampled events table

c0536ca

Wrap the trace ID column in a link to the trace details view, matching the existing behavior in the transaction events table. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat(perf): Add HTTP Method column to EAP sampled events table

1559543

Display request.method as a column before duration in the overview spans table, making it easier to distinguish between different HTTP methods at a glance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat(perf): Add User column to EAP sampled events table

f6bba2f

Display user.display (derived from user.username, user.email, user.ip, or user.id) as a column in the overview spans table. Co-Authored-By: Claude Opus 4.6 <noreply@example.com>

mjq force-pushed the mjq/eap-sampled-events-papercuts branch from 96a7068 to ab1c197 Compare March 30, 2026 01:24

vercel bot deployed to Preview March 30, 2026 01:27 View deployment

vercel bot deployed to Preview March 30, 2026 19:13 View deployment

This comment was marked as resolved.

Sign in to view

mjq force-pushed the mjq/eap-sampled-events-papercuts branch from 0fa9d8b to dbe22f5 Compare March 30, 2026 19:17

vercel bot deployed to Preview March 30, 2026 19:20 View deployment

vercel bot deployed to Preview March 30, 2026 19:26 View deployment

mjq force-pushed the mjq/eap-sampled-events-papercuts branch from ffaadd5 to 50fb9c6 Compare March 30, 2026 19:27

vercel bot deployed to Preview March 30, 2026 19:30 View deployment

mjq force-pushed the mjq/eap-sampled-events-papercuts branch from 50fb9c6 to 68d95e6 Compare March 30, 2026 19:32

vercel bot deployed to Preview March 30, 2026 19:35 View deployment

mjq force-pushed the mjq/eap-sampled-events-papercuts branch from 68d95e6 to 2f3f211 Compare March 30, 2026 19:38

vercel bot deployed to Preview March 30, 2026 19:40 View deployment

mjq force-pushed the mjq/eap-sampled-events-papercuts branch from 2f3f211 to dbe22f5 Compare March 30, 2026 19:43

vercel bot deployed to Preview March 30, 2026 19:56 View deployment

mjq force-pushed the mjq/eap-sampled-events-papercuts branch from 7704599 to b9ebdd3 Compare March 30, 2026 20:06

vercel bot deployed to Preview March 30, 2026 20:09 View deployment

mjq force-pushed the mjq/eap-sampled-events-papercuts branch from b9ebdd3 to 1b803e5 Compare March 30, 2026 20:43

vercel bot deployed to Preview March 30, 2026 20:46 View deployment

mjq and others added 7 commits March 30, 2026 16:51

add operation duration column

f6a5806

fix(perf): Clamp negative otherPercentage in operation duration break…

f5132bb

…down The `otherPercentage` value could go negative due to floating-point drift, producing an invalid negative CSS width. Use Math.max to clamp it to zero. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ref(perf): Rename OverviewSpansTable to SampledEventsTable

afeec90

Rename to match the UI label for this table. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mjq force-pushed the mjq/eap-sampled-events-papercuts branch from 1b803e5 to 5a58382 Compare March 30, 2026 20:52

vercel bot deployed to Preview March 30, 2026 20:55 View deployment

mjq added 5 commits March 30, 2026 17:34

ref(performance): De-slop EAP version of Sampled Events

d98a5ac

move percentile value mapping out of utils

72cf046

make request.method column conditional on project type

e9056fa

add test confirming switch via eap flag

80085a4

add smoke tests for new EAP components

75fe46e

mjq force-pushed the mjq/eap-sampled-events-papercuts branch from 5a58382 to 75fe46e Compare March 31, 2026 15:53

vercel bot deployed to Preview March 31, 2026 15:57 View deployment

cursor bot reviewed Mar 31, 2026

View reviewed changes

mjq closed this Mar 31, 2026

github-actions bot locked and limited conversation to collaborators Apr 16, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(performance): Restore feature parity on EAP Sampled Events tab#111731

fix(performance): Restore feature parity on EAP Sampled Events tab#111731
mjq wants to merge 20 commits intomasterfrom
mjq/eap-sampled-events-papercuts

mjq commented Mar 27, 2026 •

edited

Loading

Uh oh!

linear-code bot commented Mar 27, 2026

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

mjq commented Mar 31, 2026

Uh oh!

mjq commented Mar 31, 2026

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Mar 31, 2026

Uh oh!

mjq commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

mjq commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-code bot commented Mar 27, 2026

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

mjq commented Mar 31, 2026

Uh oh!

mjq commented Mar 31, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Mar 31, 2026

Choose a reason for hiding this comment

Table queries fire without duration filter during loading

Uh oh!

mjq commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

mjq commented Mar 27, 2026 •

edited

Loading