ref(scm): Report more granular failure metrics#111722
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
billyvg
reviewed
Mar 27, 2026
| record_count( | ||
| "sentry.scm.actions.success_by_provider", 1, {"provider": provider.__class__.__name__} | ||
| ) | ||
| record_count("sentry.scm.actions.success_by_provider", 1, {"provider": provider_name}) |
Member
There was a problem hiding this comment.
where do these metrics go? would it be better to have a single metric name w/ 2 attributes?
Member
Author
There was a problem hiding this comment.
Yes but cardinality comes at a premium and this reduces it.
Member
There was a problem hiding this comment.
yeah that's why I was wondering where we save these metrics
Member
Author
There was a problem hiding this comment.
oh I see. datadog and sentry.
billyvg
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.