Skip to content

feat(issues): Prefetch supergroup data and add stats columns to rows#111719

Merged
scttcper merged 10 commits intomasterfrom
scttcper/feat-prefetch-supergroups
Mar 30, 2026
Merged

feat(issues): Prefetch supergroup data and add stats columns to rows#111719
scttcper merged 10 commits intomasterfrom
scttcper/feat-prefetch-supergroups

Conversation

@scttcper
Copy link
Copy Markdown
Member

@scttcper scttcper commented Mar 27, 2026

Eagerly fetches supergroup assignments in the issue list overview to block the stream from rendering until grouping data is available, preventing pop-in. Supergroup rows now show aggregated stats (last seen, age, trend chart, events, users) from member groups and align to the same column grid as regular issue rows.

Removes the previous experiment.

cvxluo and others added 5 commits March 24, 2026 17:12
Co-authored-by: Claude <noreply@anthropic.com>
When issues belong to a supergroup, the supergroup summary renders as a

single row matching the issue row layout (error type, title, code area).

Matched issues are collapsed into the row showing 'X / Y issues matched'.


Co-authored-by: Claude <noreply@anthropic.com>
…group rows

Fetch supergroup assignments eagerly in overview.tsx via useSuperGroups
hook, blocking the issue stream until data is available to prevent
pop-in when issues are regrouped. Supergroup rows now display
aggregated stats (last seen, age, trend chart, event/user counts)
from member groups and align to the same grid as regular issue rows.

Co-Authored-By: Claude <noreply@anthropic.com>
@scttcper scttcper requested review from a team as code owners March 27, 2026 16:42
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 27, 2026
@scttcper scttcper marked this pull request as draft March 27, 2026 16:43
@scttcper scttcper changed the base branch from cvxluo/render-supergroup-as-single-rich-row-in-issue-feed to master March 27, 2026 16:44
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

scttcper and others added 2 commits March 27, 2026 14:00
Fix TypeScript errors in aggregateSupergroupStats by importing
TimeseriesValue from the correct module and adding non-null assertions
for bounded array access.

Simplify supergroupRow by extracting shared DataColumn base for
EventsColumn/UsersColumn, fixing AssigneeSpacer to use @container
query consistently with other columns.

Simplify buildRenderItems from two passes to a single pass and
memoize the result with useMemo.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@scttcper scttcper marked this pull request as ready for review March 27, 2026 21:19
@scttcper scttcper requested a review from a team as a code owner March 27, 2026 21:19
Copy link
Copy Markdown
Contributor

@cvxluo cvxluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏


const {supergroup, matchingIds} = item;
const memberGroups = matchingIds
.map(id => GroupStore.get(id) as Group | undefined)
Copy link
Copy Markdown
Contributor

@cvxluo cvxluo Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be good to put a limit on issues fetched here, not sure how groupstore works exactly

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.get looks at already loaded groups in the map, basically free

@scttcper scttcper enabled auto-merge (squash) March 30, 2026 19:50
@scttcper scttcper merged commit 605d033 into master Mar 30, 2026
65 checks passed
@scttcper scttcper deleted the scttcper/feat-prefetch-supergroups branch March 30, 2026 20:11
dashed pushed a commit that referenced this pull request Apr 1, 2026
…111719)

Eagerly fetches supergroup assignments in the issue list overview to
block the stream from rendering until grouping data is available,
preventing pop-in. Supergroup rows now show aggregated stats (last seen,
age, trend chart, events, users) from member groups and align to the
same column grid as regular issue rows.

Removes the previous experiment.

---------

Co-authored-by: Charlie Luo <cvxluo@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants