Skip to content

ref(scm): Move protocol definitions to types.py #111705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmanallen merged 1 commit into from
Mar 27, 2026
Merged

ref(scm): Move protocol definitions to types.py #111705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 20 additions & 22 deletions src/sentry/scm/actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,20 @@
map_repository_model_to_repository,
)
from sentry.scm.private.ipc import record_count_metric
from sentry.scm.private.provider import (
from sentry.scm.private.rate_limit import RateLimitProvider
from sentry.scm.types import (
ALL_PROTOCOLS,
SHA,
ActionResult,
ArchiveFormat,
ArchiveLink,
BranchName,
BuildConclusion,
BuildStatus,
CheckRun,
CheckRunOutput,
Comment,
Commit,
CompareCommitsProtocol,
CreateBranchProtocol,
CreateCheckRunProtocol,
Expand All @@ -38,6 +50,7 @@
DeletePullRequestCommentProtocol,
DeletePullRequestCommentReactionProtocol,
DeletePullRequestReactionProtocol,
FileContent,
GetArchiveLinkProtocol,
GetBranchProtocol,
GetCheckRunProtocol,
Expand All @@ -58,34 +71,15 @@
GetPullRequestReactionsProtocol,
GetPullRequestsProtocol,
GetTreeProtocol,
MinimizeCommentProtocol,
Provider,
RequestReviewProtocol,
UpdateBranchProtocol,
UpdateCheckRunProtocol,
UpdatePullRequestProtocol,
)
from sentry.scm.private.rate_limit import RateLimitProvider
from sentry.scm.types import (
SHA,
ActionResult,
ArchiveFormat,
ArchiveLink,
BranchName,
BuildConclusion,
BuildStatus,
CheckRun,
CheckRunOutput,
Comment,
Commit,
FileContent,
GitBlob,
GitCommitObject,
GitRef,
GitTree,
InputTreeEntry,
MinimizeCommentProtocol,
PaginatedActionResult,
PaginationParams,
Provider,
PullRequest,
PullRequestCommit,
PullRequestFile,
Expand All @@ -96,12 +90,16 @@
Repository,
RepositoryId,
RequestOptions,
RequestReviewProtocol,
ResourceId,
Review,
ReviewComment,
ReviewCommentInput,
ReviewEvent,
ReviewSide,
UpdateBranchProtocol,
UpdateCheckRunProtocol,
UpdatePullRequestProtocol,
)


Expand Down
3 changes: 1 addition & 2 deletions src/sentry/scm/private/facade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@

from sentry.scm.private.helpers import exec_provider_fn
from sentry.scm.private.ipc import record_count_metric
from sentry.scm.private.provider import ALL_PROTOCOLS, Provider
from sentry.scm.types import Referrer
from sentry.scm.types import ALL_PROTOCOLS, Provider, Referrer


def _delegating_method(name: str) -> Callable[..., Any]:
Expand Down
3 changes: 1 addition & 2 deletions src/sentry/scm/private/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@
from sentry.models.repository import Repository as RepositoryModel
from sentry.scm.errors import SCMCodedError, SCMError, SCMUnhandledException
from sentry.scm.private.ipc import record_count_metric
from sentry.scm.private.provider import Provider
from sentry.scm.private.providers.github import GitHubProvider
from sentry.scm.private.providers.gitlab import GitLabProvider
from sentry.scm.private.rate_limit import RateLimitProvider, RedisRateLimitProvider
from sentry.scm.types import ExternalId, ProviderName, Referrer, Repository, RepositoryId
from sentry.scm.types import ExternalId, Provider, ProviderName, Referrer, Repository, RepositoryId


def map_integration_to_provider(
Expand Down
Loading
Loading