feat(cells): Support multi-cell jira integration by lynnagara · Pull Request #111696 · getsentry/sentry

lynnagara · 2026-03-26T22:59:23Z

note: this is behind a feature flag for safety, the default is unchanged (no multi-cell) and merging the code should be a no-op

…on old url

sentry · 2026-03-27T14:20:18Z

+    @property
+    def is_cell_restricted(self) -> bool:
+        """
+        Returns True if each integration installation can only be connected on one cell of Sentry at a
+        time. It will raise an error if any organization from another cell attempts to install it.
+        """
+        return False


Bug: Changing is_cell_restricted to a read-only @property will cause an AttributeError in tests that attempt to directly assign a value to it, leading to test failures.
_{Severity: HIGH}

Suggested Fix

Update the tests that assign to self.provider.is_cell_restricted. Instead of direct assignment, use a mocking technique to set the property's return value for the test's duration. For example, use mock.patch.object with new_callable=mock.PropertyMock to temporarily override the property's behavior without triggering an AttributeError.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: src/sentry/integrations/base.py#L245-L251 Potential issue: The `is_cell_restricted` attribute in the `IntegrationProvider` class was converted into a read-only `@property`. However, multiple tests in `tests/sentry/integrations/test_pipeline.py` still attempt to directly assign a value to this property, such as `self.provider.is_cell_restricted = True`. Since a read-only property does not have a setter, these assignment attempts will raise an `AttributeError` at runtime. This will cause any test that calls the `_setup_cell_restriction()` helper method or directly sets the property to fail, blocking the test suite from passing.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

markstory · 2026-03-27T15:11:45Z

                            "target": {
                                "type": "web_panel",
-                                "url": "/extensions/jira/issue/{issue.key}/",
+                                "url": "/extensions/jira/issue-details/{issue.key}/",


I don't know if Jira snapshots this into the Jira instances when the extension is added. We might need to keep the old URL around as well.

markstory · 2026-03-27T15:18:22Z

+                    sentry_sdk.capture_exception(err)
+                    return self.get_response_from_control_silo()
+            # TODO(cells): Remove once all installs have migrated to JiraSentryIssueDetailsControlView.
+            return JiraSentryIssueDetailsControlView.as_view()(self.request, **self.match.kwargs)


This looks reasonable to me. This endpoint was added in #98324 with the intention of replacing the region scoped endpoint, but the transition work wasn't completed.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

github-actions · 2026-03-27T15:50:17Z

Backend Test Failures

Failures on 5876536 in this run:

tests/sentry/integrations/test_pipeline.py::ApiFinishPipelineTestCase::test_api_finish_pipeline_cell_restriction_failure — log

tests/sentry/integrations/test_pipeline.py:865: in test_api_finish_pipeline_cell_restriction_failure
    assert result.action == PipelineStepAction.ERROR
E   AssertionError: assert <PipelineStep...E: 'complete'> == <PipelineStep...RROR: 'error'>
E     
E     - error
E     + complete

tests/sentry/integrations/test_pipeline.py::FinishPipelineTestCase::test_is_violating_cell_restriction_failure — log

tests/sentry/integrations/test_pipeline.py:201: in test_is_violating_cell_restriction_failure
    assert error_message in response.content.decode()
E   assert 'This integration has already been installed on another Sentry organization which resides in a different cell. Installation could not be completed.' in '\n\n\n\n\n\n\n<!DOCTYPE html>\n<html lang="en">\n<head>\n  <meta http-equiv="content-type" content="text/html; charse...ntentLoaded\', function() {\n      insertTimezone();\n      signOutListener();\n    });</script>\n\n</body>\n</html>\n'
E    +  where '\n\n\n\n\n\n\n<!DOCTYPE html>\n<html lang="en">\n<head>\n  <meta http-equiv="content-type" content="text/html; charse...ntentLoaded\', function() {\n      insertTimezone();\n      signOutListener();\n    });</script>\n\n</body>\n</html>\n' = <built-in method decode of bytes object at 0x55e1499acb90>()
E    +    where <built-in method decode of bytes object at 0x55e1499acb90> = b'\n\n\n\n\n\n\n<!DOCTYPE html>\n<html lang="en">\n<head>\n  <meta http-equiv="content-type" content="text/html; chars...ntentLoaded\', function() {\n      insertTimezone();\n      signOutListener();\n    });</script>\n\n</body>\n</html>\n'.decode
E    +      where b'\n\n\n\n\n\n\n<!DOCTYPE html>\n<html lang="en">\n<head>\n  <meta http-equiv="content-type" content="text/html; chars...ntentLoaded\', function() {\n      insertTimezone();\n      signOutListener();\n    });</script>\n\n</body>\n</html>\n' = <HttpResponse status_code=200, "text/html">.content

tests/sentry/integrations/test_pipeline.py::FinishPipelineTestCase::test_provider_should_check_cell_violation — log

tests/sentry/integrations/test_pipeline.py:153: in test_provider_should_check_cell_violation
    assert mock_check_violation.called
E   AssertionError: assert False
E    +  where False = <MagicMock name='is_violating_cell_restriction' id='140154799137728'>.called

github-actions · 2026-03-27T16:09:44Z

Backend Test Failures

Failures on c5f1519 in this run:

tests/sentry/integrations/test_pipeline.py::FinishPipelineTestCase::test_is_violating_cell_restriction_failure — log

tests/sentry/integrations/test_pipeline.py:180: in test_is_violating_cell_restriction_failure
    assert error_message in response.content.decode()
E   assert 'This integration has already been installed on another Sentry organization which resides in a different cell. Installation could not be completed.' in '\n\n\n\n\n\n\n<!DOCTYPE html>\n<html lang="en">\n<head>\n  <meta http-equiv="content-type" content="text/html; charse...ntentLoaded\', function() {\n      insertTimezone();\n      signOutListener();\n    });</script>\n\n</body>\n</html>\n'
E    +  where '\n\n\n\n\n\n\n<!DOCTYPE html>\n<html lang="en">\n<head>\n  <meta http-equiv="content-type" content="text/html; charse...ntentLoaded\', function() {\n      insertTimezone();\n      signOutListener();\n    });</script>\n\n</body>\n</html>\n' = <built-in method decode of bytes object at 0x562011887f10>()
E    +    where <built-in method decode of bytes object at 0x562011887f10> = b'\n\n\n\n\n\n\n<!DOCTYPE html>\n<html lang="en">\n<head>\n  <meta http-equiv="content-type" content="text/html; chars...ntentLoaded\', function() {\n      insertTimezone();\n      signOutListener();\n    });</script>\n\n</body>\n</html>\n'.decode
E    +      where b'\n\n\n\n\n\n\n<!DOCTYPE html>\n<html lang="en">\n<head>\n  <meta http-equiv="content-type" content="text/html; chars...ntentLoaded\', function() {\n      insertTimezone();\n      signOutListener();\n    });</script>\n\n</body>\n</html>\n' = <HttpResponse status_code=200, "text/html">.content

tests/sentry/integrations/test_pipeline.py::ApiFinishPipelineTestCase::test_api_finish_pipeline_cell_restriction_failure — log

tests/sentry/integrations/test_pipeline.py:844: in test_api_finish_pipeline_cell_restriction_failure
    assert result.action == PipelineStepAction.ERROR
E   AssertionError: assert <PipelineStep...E: 'complete'> == <PipelineStep...RROR: 'error'>
E     
E     - error
E     + complete

feat(cells): Support multi-cell jira integration

824f18e

note: this is behind a feature flag for safety, the default is unchanged (no multi-cell) and merging the code should be a no-op

lynnagara requested a review from a team March 26, 2026 22:59

lynnagara requested review from a team as code owners March 26, 2026 22:59

vercel bot deployed to Preview March 26, 2026 22:59 View deployment

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 26, 2026

cursor bot reviewed Mar 26, 2026

View reviewed changes

Comment thread src/sentry/middleware/integrations/parsers/jira.py

lynnagara added 3 commits March 26, 2026 16:23

add todo

441ce0f

add backward compat -- delegate to issue-details if multicell called …

e87367a

…on old url

fix type issue

69f2bdd

vercel bot deployed to Preview March 26, 2026 23:39 View deployment

vercel bot deployed to Preview March 26, 2026 23:42 View deployment

.

2e299cc

vercel bot deployed to Preview March 27, 2026 14:19 View deployment

sentry bot reviewed Mar 27, 2026

View reviewed changes

markstory reviewed Mar 27, 2026

View reviewed changes

markstory approved these changes Mar 27, 2026

View reviewed changes

fix typing for real

5f7c37b

vercel bot deployed to Preview March 27, 2026 15:43 View deployment

cursor bot reviewed Mar 27, 2026

View reviewed changes

Comment thread tests/sentry/integrations/test_pipeline.py Outdated

doesn't test anything useful, remove tests

3fc8f9f

vercel bot deployed to Preview March 27, 2026 16:01 View deployment

adjust tests

a5b912d

vercel bot deployed to Preview March 27, 2026 19:08 View deployment

markstory approved these changes Mar 30, 2026

View reviewed changes

lynnagara merged commit aed48e0 into master Mar 30, 2026
89 of 90 checks passed

lynnagara deleted the multicell-jira-support branch March 30, 2026 18:04

github-actions bot locked and limited conversation to collaborators Apr 15, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(cells): Support multi-cell jira integration#111696

feat(cells): Support multi-cell jira integration#111696
lynnagara merged 8 commits intomasterfrom
multicell-jira-support

lynnagara commented Mar 26, 2026

Uh oh!

Uh oh!

sentry bot Mar 27, 2026

Uh oh!

markstory Mar 27, 2026

Uh oh!

markstory Mar 27, 2026

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 27, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

lynnagara commented Mar 26, 2026

Uh oh!

Uh oh!

sentry bot Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

markstory Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

markstory Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backend Test Failures

Uh oh!

github-actions bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backend Test Failures

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Mar 27, 2026 •

edited

Loading

github-actions bot commented Mar 27, 2026 •

edited

Loading