fix(aci): Include project alerts on monitor list page#111690
fix(aci): Include project alerts on monitor list page#111690
Conversation
github-actions
bot
added
the
Scope: Frontend
| automationIds: string[]; | ||
| projectId: string; |
There was a problem hiding this comment.
Nit: could we use an Indexed Access Type for these? Project["id"] kind of thing, so we can rely on a single type defintion?
| }); | ||
| return useDetectorsQuery( | ||
| { | ||
| query: 'type:issue_stream', |
There was a problem hiding this comment.
just curious.. how hard would it be to rename the IssueStream to Issue Feed for ui components? (something tells me that issue stream isn't going to stick around, so mostly just trying to understand the blast radius)
There was a problem hiding this comment.
The only user-facing place that we show "issue stream" is when connecting monitors to an alert:
The blast radius is pretty small
| automationIds={detector.workflowIds} | ||
| projectId={detector.projectId} |
There was a problem hiding this comment.
nit: should we just pass the detector as the prop so we can strictly type it and have access to any other data we might need?
2 participants
Closes ISWF-2228
On the monitor list views we are only showing the directly-connected alerts. The detail pages already show the full list including project-connected alerts. This simply adds the functionality to the list view.
Before:
After:
